Skip to content

test(node): collect TypeSafe spans across streamed envelopes - #26151

Merged
nicohrubec merged 1 commit into
developfrom
fix/typesafe-streamed-span-collection
Nov 6, 2026
Merged

nicohrubec merged 1 commit into
developfrom
fix/typesafe-streamed-span-collection

Conversation

@nicohrubec

@nicohrubec nicohrubec commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Why: TypeSafe integration tests assume all four decide spans arrive in one streamed container. Collecting across envelopes removes that batching assumption while preserving every span assertion, including waiting for late children after the main segment. Not sure if this actually fixes it but worth a shot I have seen this flake couple of times.

Co-Authored-By: OpenAI Codex <codex@openai.com>
@nicohrubec
nicohrubec marked this pull request as ready for review November 5, 2026 15:08
@nicohrubec
nicohrubec requested a review from a team as a code owner November 5, 2026 15:08
@nicohrubec
nicohrubec requested review from andreiborza, isaacs and mydea and removed request for a team November 5, 2026 15:08
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: 953fd61 (PR test merge using develop at eb0e92e)

Against: eb0e92e (develop) · base run #65112

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.4 kB - -
@sentry/browser - with treeshaking flags 28.54 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.43 kB - -
@sentry/browser (incl. Tracing) 52.73 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.73 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.7 kB - -
@sentry/browser (incl. Tracing, Replay) 93.03 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.63 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.78 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.77 kB - -
@sentry/browser (incl. Feedback) 47.98 kB - -
@sentry/browser (incl. sendFeedback) 35.5 kB - -
@sentry/browser (incl. FeedbackAsync) 40.61 kB - -
@sentry/browser (incl. Metrics) 31.44 kB - -
@sentry/browser (incl. Logs) 31.73 kB - -
@sentry/browser (incl. Metrics & Logs) 32.45 kB - -
@sentry/react 32.29 kB - -
@sentry/react (incl. Tracing) 55.1 kB - -
@sentry/vue 38.67 kB - -
@sentry/vue (incl. Tracing) 55.75 kB - -
@sentry/svelte 30.43 kB - -
@sentry/remix (Remix 3 client bundle) 57.82 kB - -
CDN Bundle 32.2 kB - -
CDN Bundle (incl. Tracing) 53.26 kB - -
CDN Bundle (incl. Logs, Metrics) 34.47 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.2 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.88 kB - -
CDN Bundle (incl. Tracing, Replay) 91.47 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.4 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 97.58 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 99.58 kB - -
CDN Bundle - uncompressed 94.67 kB - -
CDN Bundle (incl. Tracing) - uncompressed 157.67 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.14 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.41 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 232.71 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 279.36 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 285.08 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 293.06 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 298.77 kB - -
@sentry/nextjs (client) 58.05 kB - -
@sentry/sveltekit (client) 53.24 kB - -
@sentry/core/server 44.25 kB - -
@sentry/core/browser 13.93 kB - -
@sentry/node 156.6 kB +0.02% +22 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.28 kB - -
@sentry/node - without tracing 96.91 kB +0.02% +18 B 🔺
@sentry/node - without channel injection 136.94 kB +0.02% +17 B 🔺
@sentry/aws-serverless 105.26 kB +0.02% +17 B 🔺
@sentry/cloudflare (withSentry) - minified 200.67 kB - -
@sentry/cloudflare (withSentry) 499.05 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 222.67 kB - -

View base workflow run

@nicohrubec
nicohrubec merged commit 4c9a4eb into develop Nov 6, 2026
63 checks passed
@nicohrubec
nicohrubec deleted the fix/typesafe-streamed-span-collection branch November 6, 2026 08:32
43081j pushed a commit to 43081j/sentry-javascript that referenced this pull request Nov 9, 2026
…ry#26151)

**Why:** TypeSafe integration tests assume all four decide spans arrive
in one streamed container. Collecting across envelopes removes that
batching assumption while preserving every span assertion, including
waiting for late children after the `main` segment. Not sure if this
actually fixes it but worth a shot I have seen this flake couple of
times.

Co-authored-by: OpenAI Codex <codex@openai.com>
s1gr1d added a commit that referenced this pull request Nov 17, 2026
…es (#26480)

❗ Use "Hide Whitespace" to only see around 50 LOC changed.

## What

- Four `apollo-graphql/useOperationNameForRootSpan` tests and the Mastra
multi-instance test collect the spans of a trace with
`collectStreamedSpansUntilSegment`, and assert on the collected spans.
- The `auto-flush` preload of the test runner registers its `beforeExit`
handler with `once`.



## Why

With span streaming, the SDK flushes 500 ms after any segment ends. The
spans of one trace can then arrive in two envelopes. These tests
asserted the whole trace on the first envelope and failed about 20 times
in the last month when the trace was split. #26151 fixed the same
pattern for the typesafe suite. Every assertion on names, attributes,
origins, and status is unchanged.

One difference: an error event that arrives before the first span
envelope no longer fails these tests, because a collector reads span
envelopes only.

The `auto-flush` change is not a flake fix. `flush()` sets a timer, so
`beforeExit` fired again after each flush and a finished scenario never
exited. A test with an expectation that was not met waited for the full
15 s timeout; it now fails in about 3 s with "Scenario exited".

Ref #26477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants