Skip to content

spec(sdk): add sentry.is_localhost attribute to logs, metrics, and spans - #19559

Merged
cleptric merged 3 commits into
masterfrom
add-is-localhost
Sep 23, 2026
Merged

cleptric merged 3 commits into
masterfrom
add-is-localhost

Conversation

@cleptric

@cleptric cleptric commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Add a new common default attribute sentry.is_localhost (boolean) to the logs, metrics, and spans SDK specs. This attribute is used to enable the localhost inbound filter.

Add a new common default attribute `sentry.is_localhost` (boolean) across
all three telemetry types to enable the localhost inbound filter. The
definition of "localhost" is platform-specific per SDK.

- Logs spec bumped to 2.3.0
- Metrics spec bumped to 2.11.0
- Spans common attribute keys table updated

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
develop-docs Ready Ready Preview Sep 23, 2026 10:33am UTC
1 Skipped Deployment
Project Deployment Actions Updated
sentry-docs Ignored Ignored Preview Sep 23, 2026 10:33am UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T14:48:09.663026Z ea2911e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added sdk-develop-docs PRs touching develop-docs/sdk Priority: Normal Docs review has no urgent deadline labels Sep 22, 2026
chatgpt-codex-connector[bot]

This comment was marked as spam.

Comment thread develop-docs/sdk/telemetry/logs.mdx Resolved
@github-actions github-actions Bot added Priority: Needs Triage The PR description is missing valid priority information and removed Priority: Normal Docs review has no urgent deadline labels Sep 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Please update the IS YOUR CHANGE URGENT? section of the PR description:

  • Select exactly one option.
  • If you selected an urgent or other deadline, provide the date as YYYY-MM-DD.

This information helps the Docs team prioritize your review.

@cleptric cleptric removed the Priority: Needs Triage The PR description is missing valid priority information label Sep 22, 2026
Comment thread develop-docs/sdk/telemetry/logs.mdx Resolved
Lms24 added a commit to getsentry/sentry-javascript that referenced this pull request Sep 23, 2026
Following getsentry/sentry-conventions#646, this
PR adds the new `is_localhost` attribute which we'll use to indicate to
Relay/Sentry backend, whether the "filter out events coming from
localhost" inbound filter should filter out spans or not.

See the conventions PR for reasoning why we ended up with this attribute
rather than something more general.

See develop spec update for streamed spans:
getsentry/sentry-docs#19559

Adding this is pretty, easy, as we can do it via
`requestDataIntegration` for server, and `httpContextIntegration` for
browser.
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Comment thread develop-docs/sdk/telemetry/logs.mdx Resolved
@cleptric
cleptric merged commit e5f3b64 into master Sep 23, 2026
22 checks passed
@cleptric
cleptric deleted the add-is-localhost branch September 23, 2026 10:39
inventarSarah pushed a commit that referenced this pull request Sep 29, 2026
…ans (#19559)

Add a new common default attribute `sentry.is_localhost` (boolean) to
the logs, metrics, and spans SDK specs. This attribute is used to enable
the localhost inbound filter.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>

This branch was successfully deployed

1 active deployment
Preview – develop-docs — 1b3eb63c Deployed Sep 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk-develop-docs PRs touching develop-docs/sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants