Repository navigation
spec(sdk): add sentry.is_localhost attribute to logs, metrics, and spans - #19559
Merged
Merged
Conversation
Add a new common default attribute `sentry.is_localhost` (boolean) across all three telemetry types to enable the localhost inbound filter. The definition of "localhost" is platform-specific per SDK. - Logs spec bumped to 2.3.0 - Metrics spec bumped to 2.11.0 - Spans common attribute keys table updated Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
cleptric
requested review from
Lms24,
alexander-alderman-webb,
buenaflor and
sentrivana
September 22, 2026 14:52
Contributor
|
Please update the IS YOUR CHANGE URGENT? section of the PR description:
This information helps the Docs team prioritize your review. |
Lms24
approved these changes
Sep 22, 2026
Lms24
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Sep 23, 2026
Following getsentry/sentry-conventions#646, this PR adds the new `is_localhost` attribute which we'll use to indicate to Relay/Sentry backend, whether the "filter out events coming from localhost" inbound filter should filter out spans or not. See the conventions PR for reasoning why we ended up with this attribute rather than something more general. See develop spec update for streamed spans: getsentry/sentry-docs#19559 Adding this is pretty, easy, as we can do it via `requestDataIntegration` for server, and `httpContextIntegration` for browser.
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
inventarSarah
pushed a commit
that referenced
this pull request
Sep 29, 2026
…ans (#19559) Add a new common default attribute `sentry.is_localhost` (boolean) to the logs, metrics, and spans SDK specs. This attribute is used to enable the localhost inbound filter. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new common default attribute
sentry.is_localhost(boolean) to the logs, metrics, and spans SDK specs. This attribute is used to enable the localhost inbound filter.