Skip to content

feat(heroku): Add Heroku log drain attributes - #772

Merged
Dav1dde merged 1 commit into
mainfrom
dav1d/heroku-log-drain2
Nov 5, 2026
Merged

Dav1dde merged 1 commit into
mainfrom
dav1d/heroku-log-drain2

Conversation

@Dav1dde

@Dav1dde Dav1dde commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Description

Missing Heroku attributes, replaces #762

This follow the Heroku OTeL docs as well as OTeL's provider mapping.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for apply_scrubbing (i.e. manual or auto. Use never only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-conventions Ready Ready Preview Nov 5, 2026 10:45am UTC

Request Review

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add Vercel AI runtime and tool context attributes by isaacs and claude in #756
  • Register user.geo.subregion and deprecated sentry.user.geo.subregion by edwardgou-sentry in #753
  • Add faas.instance attribute by pabloDeputter in #748
  • Add faas.document.* attributes by pabloDeputter in #747
  • Add page.server_rendering.type attribute by s1gr1d in #740

Other

  • (heroku) Add Heroku log drain attributes by Dav1dde in #772
  • (metrics) Generate metric name constants under a metrics subpath by logaretm in #757

Bug Fixes 🐛

  • (attributes) Use response for tool_call_response in gen_ai.input.messages example by alexander-alderman-webb in #758

Internal Changes 🔧

  • Remove finish_reason from gen_ai.output.message example by alexander-alderman-webb in #759
  • Deprecate gen_ai.handoff op by alexander-alderman-webb in #754

🤖 This preview updates automatically when you update the PR.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5a82fb0. Configure here.

@Dav1dde
Dav1dde force-pushed the dav1d/heroku-log-drain2 branch from 5a82fb0 to 1dae824 Compare November 5, 2026 10:45
@Dav1dde
Dav1dde merged commit 46aebaa into main Nov 5, 2026
18 checks passed
@Dav1dde
Dav1dde deleted the dav1d/heroku-log-drain2 branch November 5, 2026 10:49

This branch was successfully deployed

1 active deployment
Preview — 1dae8243 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants