Skip to content

feat(model): add Elixir runtime metrics - #768

Merged
solnic merged 1 commit into
mainfrom
feat/elixir-metrics
Nov 11, 2026
Merged

solnic merged 1 commit into
mainfrom
feat/elixir-metrics

Conversation

@solnic

@solnic solnic commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-conventions Ready Ready Preview Nov 11, 2026 1:57pm UTC

Request Review

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add TypeScript type generation from OpenAPI schemas by alexander-alderman-webb in #771
  • Add Python type generation from OpenAPI schemas by alexander-alderman-webb in #769
  • Add schema for gen_ai.tool.definitions by alexander-alderman-webb in #767

Other

  • (model) Add Elixir runtime metrics by solnic in #768

Bug Fixes 🐛

  • (attributes) Describe pageload links for cache_origin and server_request by s1gr1d in #789

Internal Changes 🔧

  • (codeowners) Move gen_ai attribute ownership to agent-tracing by shellmayr in #792

🤖 This preview updates automatically when you update the PR.

@alexander-alderman-webb alexander-alderman-webb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from my perspective.
Wait 2 days before merging please so other's can take a look.

Name the metrics and their attributes under process.runtime.elixir.*, following the OTel process.runtime.<runtime>.* pattern.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1709516. Configure here.

@@ -0,0 +1,17 @@
{
"key": "process.runtime.elixir.memory.type",
"brief": "The kind of BEAM memory a measurement covers: processes, atom, binary, code, ets, or other for the rest of the VM total.",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closed type values missing enums

Medium Severity

process.runtime.elixir.memory.type and process.runtime.elixir.run_queue.type describe a closed set of strings in brief (processes, atom, binary, code, ets, other; and cpu, io). Closed string attributes use enum_values with a brief per value, rather than packing that list into brief.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by learned rule: Closed string values go in enum_values

Reviewed by Cursor Bugbot for commit 1709516. Configure here.

"instrument": "gauge",
"unit": "none",
"is_in_otel": false,
"requirement_level": "opt_in"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime metrics wrongly marked opt-in

Medium Severity

All twelve Elixir runtime gauges set requirement_level to opt_in with no noisiness rationale. requirement_level is relative to an already-enabled metrics integration; opt_in is only for signals that need a further dedicated flag. Existing metrics in this repo use recommended.

Additional Locations (2)
Fix in Cursor Fix in Web

Triggered by learned rule: Metric requirement_level is post-opt-in

Reviewed by Cursor Bugbot for commit 1709516. Configure here.

@solnic
solnic merged commit 38992f8 into main Nov 11, 2026
18 checks passed
@solnic
solnic deleted the feat/elixir-metrics branch November 11, 2026 14:05
solnic added a commit to getsentry/sentry-elixir that referenced this pull request Nov 11, 2026
Report runtime metrics under process.runtime.elixir.* as defined in
sentry-conventions (getsentry/sentry-conventions#768):

- process.runtime.elixir.memory.used, one gauge per
  process.runtime.elixir.memory.type (processes, atom, binary, code,
  ets, other), replacing the elixir.runtime.mem.* gauges
- process.runtime.elixir.run_queue.length, one gauge per
  process.runtime.elixir.run_queue.type (cpu, io), replacing the
  elixir.runtime.run_queue.* gauges
- process.runtime.elixir.{process,atom,port}.{count,limit,utilization}
  and process.runtime.elixir.scheduler.utilization
- unit "none" for counts, and the OTel process.runtime.* attributes
  in place of elixir_version and otp_release when version_attributes
  is enabled

Document the units Sentry recognizes in Sentry.Metrics.

Add `mix test.conventions` and a workflow that check the emitted
metrics against the definitions in a sentry-conventions checkout.
solnic added a commit to getsentry/sentry-elixir that referenced this pull request Nov 13, 2026
Report runtime metrics under process.runtime.elixir.* as defined in
sentry-conventions (getsentry/sentry-conventions#768):

- process.runtime.elixir.memory.used, one gauge per
  process.runtime.elixir.memory.type (processes, atom, binary, code,
  ets, other), replacing the elixir.runtime.mem.* gauges
- process.runtime.elixir.run_queue.length, one gauge per
  process.runtime.elixir.run_queue.type (cpu, io), replacing the
  elixir.runtime.run_queue.* gauges
- process.runtime.elixir.{process,atom,port}.{count,limit,utilization}
  and process.runtime.elixir.scheduler.utilization
- unit "none" for counts, and the OTel process.runtime.* attributes
  in place of elixir_version and otp_release when version_attributes
  is enabled

Document the units Sentry recognizes in Sentry.Metrics.

Add `mix test.conventions` and a workflow that check the emitted
metrics against the definitions in a sentry-conventions checkout.

This branch was successfully deployed

1 active deployment
Preview — 1709516b Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants