Repository navigation
feat(model): add Elixir runtime metrics - #768
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
e0c513b to
870831e
Compare
870831e to
acd02ad
Compare
acd02ad to
1234d18
Compare
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
Good from my perspective.
Wait 2 days before merging please so other's can take a look.
1234d18 to
73efee0
Compare
Name the metrics and their attributes under process.runtime.elixir.*, following the OTel process.runtime.<runtime>.* pattern.
73efee0 to
1709516
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1709516. Configure here.
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "key": "process.runtime.elixir.memory.type", | |||
| "brief": "The kind of BEAM memory a measurement covers: processes, atom, binary, code, ets, or other for the rest of the VM total.", | |||
There was a problem hiding this comment.
Closed type values missing enums
Medium Severity
process.runtime.elixir.memory.type and process.runtime.elixir.run_queue.type describe a closed set of strings in brief (processes, atom, binary, code, ets, other; and cpu, io). Closed string attributes use enum_values with a brief per value, rather than packing that list into brief.
Additional Locations (1)
Triggered by learned rule: Closed string values go in enum_values
Reviewed by Cursor Bugbot for commit 1709516. Configure here.
| "instrument": "gauge", | ||
| "unit": "none", | ||
| "is_in_otel": false, | ||
| "requirement_level": "opt_in" |
There was a problem hiding this comment.
Runtime metrics wrongly marked opt-in
Medium Severity
All twelve Elixir runtime gauges set requirement_level to opt_in with no noisiness rationale. requirement_level is relative to an already-enabled metrics integration; opt_in is only for signals that need a further dedicated flag. Existing metrics in this repo use recommended.
Additional Locations (2)
Triggered by learned rule: Metric requirement_level is post-opt-in
Reviewed by Cursor Bugbot for commit 1709516. Configure here.
Report runtime metrics under process.runtime.elixir.* as defined in sentry-conventions (getsentry/sentry-conventions#768): - process.runtime.elixir.memory.used, one gauge per process.runtime.elixir.memory.type (processes, atom, binary, code, ets, other), replacing the elixir.runtime.mem.* gauges - process.runtime.elixir.run_queue.length, one gauge per process.runtime.elixir.run_queue.type (cpu, io), replacing the elixir.runtime.run_queue.* gauges - process.runtime.elixir.{process,atom,port}.{count,limit,utilization} and process.runtime.elixir.scheduler.utilization - unit "none" for counts, and the OTel process.runtime.* attributes in place of elixir_version and otp_release when version_attributes is enabled Document the units Sentry recognizes in Sentry.Metrics. Add `mix test.conventions` and a workflow that check the emitted metrics against the definitions in a sentry-conventions checkout.
Report runtime metrics under process.runtime.elixir.* as defined in sentry-conventions (getsentry/sentry-conventions#768): - process.runtime.elixir.memory.used, one gauge per process.runtime.elixir.memory.type (processes, atom, binary, code, ets, other), replacing the elixir.runtime.mem.* gauges - process.runtime.elixir.run_queue.length, one gauge per process.runtime.elixir.run_queue.type (cpu, io), replacing the elixir.runtime.run_queue.* gauges - process.runtime.elixir.{process,atom,port}.{count,limit,utilization} and process.runtime.elixir.scheduler.utilization - unit "none" for counts, and the OTel process.runtime.* attributes in place of elixir_version and otp_release when version_attributes is enabled Document the units Sentry recognizes in Sentry.Metrics. Add `mix test.conventions` and a workflow that check the emitted metrics against the definitions in a sentry-conventions checkout.


Refs getsentry/sentry-elixir#1235