Skip to content

feat(attributes): Add faas.document.* attributes - #747

Merged
pabloDeputter merged 4 commits into
mainfrom
feat/faas-document-attributes
Oct 30, 2026
Merged

pabloDeputter merged 4 commits into
mainfrom
feat/faas-document-attributes

Conversation

@pabloDeputter

Copy link
Copy Markdown
Contributor

Description

Add faas.document.* attributes for e.g. AWS Lambda invocations triggered by S3 notifications and DynamoDB streams: faas.document.collection, faas.document.name, faas.document.operation, faas.document.time. All are already defined in OTel.

Use auto scrubbing on faas.document.name since it holds object keys and file names, which can hold user IDs, emails, etc.

Issues

Resolves #731 & CON-110

@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-conventions Ready Ready Preview Oct 30, 2026 12:58pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add faas.document.* attributes by pabloDeputter and claude in #747
  • Add page.server_rendering.type attribute by s1gr1d in #740

Internal Changes 🔧

  • Deprecate gen_ai.handoff op by alexander-alderman-webb in #754

🤖 This preview updates automatically when you update the PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because these attributes are defined by OTel so we might as well use them.
On a general note, it seems like these attributes have a lot of similariy to db.* attributes, so I'm wondering a bit why we need them. I assume the broadness of the "document" is likely the reason.

@pabloDeputter

Copy link
Copy Markdown
Contributor Author

From my understanding (aws lambda example): db.* attributes are for spans that represent operations on a database; faas.document.* is for the lambda invocation span that a data change triggered:

Service A can add a new row to table Orders, the span will get db.operation.name=PutItem; db.collection.name=orders. This triggers a lambda invocation (if configured) with attributes faas.document.operation=insert;faas.document.collection=orders.

@Lms24

Lms24 commented Oct 28, 2026

Copy link
Copy Markdown
Member

Thx for explaining! I think it's fine to use the faas attributes for these spans.

@pabloDeputter
pabloDeputter enabled auto-merge (squash) October 30, 2026 12:57
@pabloDeputter
pabloDeputter merged commit 444cadd into main Oct 30, 2026
18 checks passed
@pabloDeputter
pabloDeputter deleted the feat/faas-document-attributes branch October 30, 2026 13:00

This branch was successfully deployed

1 active deployment
Preview — e73b27a5 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(attributes): Add faas.document.* attributes

2 participants