Repository navigation
feat(attributes): Add faas.document.* attributes - #747
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lms24
left a comment
There was a problem hiding this comment.
Approving because these attributes are defined by OTel so we might as well use them.
On a general note, it seems like these attributes have a lot of similariy to db.* attributes, so I'm wondering a bit why we need them. I assume the broadness of the "document" is likely the reason.
|
From my understanding (aws lambda example): Service A can add a new row to table Orders, the span will get |
|
Thx for explaining! I think it's fine to use the |
Description
Add
faas.document.*attributes for e.g. AWS Lambda invocations triggered by S3 notifications and DynamoDB streams:faas.document.collection,faas.document.name,faas.document.operation,faas.document.time. All are already defined in OTel.Use auto scrubbing on
faas.document.namesince it holds object keys and file names, which can hold user IDs, emails, etc.Issues
Resolves #731 & CON-110