Skip to content

ref: Limit device.name to mobile devices and alias server_name to server.address - #647

Merged
Lms24 merged 4 commits into
mainfrom
webb/device-name
Sep 23, 2026
Merged

Lms24 merged 4 commits into
mainfrom
webb/device-name

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

Change the device.name brief.
As a result of the change, server_name no longer matches the brief for device.name.
Therefore, alias server_name to server.address instead.

Closes #644

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for apply_scrubbing (i.e. manual or auto. Use never only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add internal sentry.is_localhost attribute by Lms24 in #646
  • Add the INP target and interaction type attributes by logaretm in #641
  • Deprecate the web vital report event attributes by logaretm in #642
  • Add React Native native module call attributes by alwx in #564
  • Use the web-vitals navigation types as-is for browser.navigation.type by logaretm in #640
  • Add legacy gen_ai cache token attributes (deprecated) by JPeer264 in #582

Other

  • (names) Add span name and description conventions for ui.* ops by Lms24 in #643
  • (op) Add ui.resolve span op by Lms24 in #633
  • (replays) Define replayId as a deprecated attribute by mjq in #401

Internal Changes 🔧

Deps

  • Bump devalue from 5.8.1 to 5.9.2 by dependabot in #639
  • Bump smol-toml from 1.6.1 to 1.8.0 by dependabot in #635

Other

  • Limit device.name to mobile devices and alias server_name to server.address by alexander-alderman-webb in #647
  • Broaden server.address brief to also allow hostnames by alexander-alderman-webb in #645

🤖 This preview updates automatically when you update the PR.

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 22, 2026 14:39
Base automatically changed from webb/server-address to main September 23, 2026 06:54
@Lms24
Lms24 merged commit df5f1e5 into main Sep 23, 2026
17 checks passed
@Lms24
Lms24 deleted the webb/device-name branch September 23, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix server_name alias

2 participants