Skip to content

feat(attributes): Add stable app vitals attributes - #493

Merged
buenaflor merged 4 commits into
mainfrom
feat/app-vitals-derived-attributes
Jul 16, 2026
Merged

buenaflor merged 4 commits into
mainfrom
feat/app-vitals-derived-attributes

Conversation

@buenaflor

Copy link
Copy Markdown
Contributor

Description

Adds stable app.vitals.* names for derived mobile performance attributes:

  • frames_frozen_rate → app.vitals.frames.frozen.rate
  • frames_slow_rate → app.vitals.frames.slow.rate
  • stall_total_time → app.vitals.stall.duration
  • stall_percentage → app.vitals.stall.percentage

Deprecates the legacy names with bidirectional aliases and backfill status, updates measurement mappings, and regenerates the JavaScript and Python bindings.

The OpenTelemetry application registry was checked and has no exact equivalents for these derived frame rates or React Native stall aggregates.

Testing

  • yarn test:js — 7,480 passed
  • yarn test:python — 3 passed
  • yarn lint
  • git diff --check

Closes #372

@github-actions

github-actions Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add stable app vitals attributes by buenaflor in #493
  • Deprecate sentry.frames.* attributes by buenaflor in #500
  • Add missing AI legacy aliases from Relay SpanData by vgrozdanic in #498

Internal Changes 🔧

  • (attrs) Backport attributes and normalizations from Relay by Dav1dde in #497
  • (codeowners) Assign telemetry-experience to gen_ai/ai attributes by vgrozdanic in #506
  • (release) Show version in workflow run title by constantinius in #504

🤖 This preview updates automatically when you update the PR.

@buenaflor
buenaflor force-pushed the feat/app-vitals-derived-attributes branch from 8c7b686 to 3925c56 Compare July 13, 2026 14:46
@buenaflor
buenaflor marked this pull request as ready for review July 13, 2026 14:57
@buenaflor
buenaflor requested review from Lms24 and cleptric as code owners July 13, 2026 14:57
Copilot AI review requested due to automatic review settings July 13, 2026 14:57
@buenaflor
buenaflor requested review from a team, mjq and nsdeschenes as code owners July 13, 2026 14:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds stable app.vitals.* attribute names for derived mobile performance metrics (frame rates and React Native stall aggregates), while keeping legacy names working via bidirectional aliases and backfill deprecations. This fits the codebase’s role as the source-of-truth schema + generated bindings for Sentry attribute/measurement conventions.

Changes:

  • Introduces new stable attributes: app.vitals.frames.{frozen,slow}.rate, app.vitals.stall.{duration,percentage}.
  • Deprecates legacy attributes (frames_frozen_rate, frames_slow_rate, stall_total_time, stall_percentage) with aliases + backfill deprecation metadata.
  • Updates measurement→attribute mappings and regenerates Python/TypeScript bindings and metadata maps.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
python/src/sentry_conventions/attributes.py Adds new stable constants + metadata; marks legacy attributes deprecated with aliases/backfill; updates type mappings.
model/measurements/stall_total_time.json Maps the stall_total_time measurement to app.vitals.stall.duration.
model/measurements/stall_percentage.json Maps the stall_percentage measurement to app.vitals.stall.percentage.
model/measurements/frames_slow_rate.json Maps the frames_slow_rate measurement to app.vitals.frames.slow.rate.
model/measurements/frames_frozen_rate.json Maps the frames_frozen_rate measurement to app.vitals.frames.frozen.rate.
model/attributes/stall_total_time.json Deprecates legacy attribute in favor of app.vitals.stall.duration with alias + backfill status.
model/attributes/stall_percentage.json Deprecates legacy attribute in favor of app.vitals.stall.percentage with alias + backfill status.
model/attributes/frames_slow_rate.json Deprecates legacy attribute in favor of app.vitals.frames.slow.rate with alias + backfill status.
model/attributes/frames_frozen_rate.json Deprecates legacy attribute in favor of app.vitals.frames.frozen.rate with alias + backfill status.
model/attributes/app/app__vitals__stall__percentage.json Defines new stable app.vitals.stall.percentage attribute + alias from legacy.
model/attributes/app/app__vitals__stall__duration.json Defines new stable app.vitals.stall.duration attribute + alias from legacy.
model/attributes/app/app__vitals__frames__slow__rate.json Defines new stable app.vitals.frames.slow.rate attribute + alias from legacy.
model/attributes/app/app__vitals__frames__frozen__rate.json Defines new stable app.vitals.frames.frozen.rate attribute + alias from legacy.
javascript/sentry-conventions/src/attributes.ts Regenerates TS exports/types/metadata for new stable attributes and legacy deprecations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@buenaflor
buenaflor enabled auto-merge (squash) July 16, 2026 07:37
@buenaflor
buenaflor merged commit 2e7ce45 into main Jul 16, 2026
16 checks passed
@buenaflor
buenaflor deleted the feat/app-vitals-derived-attributes branch July 16, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new stable attributes for frames_frozen_rate, frames_slow_rate, stall_total_time, stall_percentage

3 participants