Repository navigation
feat(attributes): Add stable app vitals attributes - #493
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
8c7b686 to
3925c56
Compare
There was a problem hiding this comment.
Pull request overview
Adds stable app.vitals.* attribute names for derived mobile performance metrics (frame rates and React Native stall aggregates), while keeping legacy names working via bidirectional aliases and backfill deprecations. This fits the codebase’s role as the source-of-truth schema + generated bindings for Sentry attribute/measurement conventions.
Changes:
- Introduces new stable attributes:
app.vitals.frames.{frozen,slow}.rate,app.vitals.stall.{duration,percentage}. - Deprecates legacy attributes (
frames_frozen_rate,frames_slow_rate,stall_total_time,stall_percentage) with aliases +backfilldeprecation metadata. - Updates measurement→attribute mappings and regenerates Python/TypeScript bindings and metadata maps.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| python/src/sentry_conventions/attributes.py | Adds new stable constants + metadata; marks legacy attributes deprecated with aliases/backfill; updates type mappings. |
| model/measurements/stall_total_time.json | Maps the stall_total_time measurement to app.vitals.stall.duration. |
| model/measurements/stall_percentage.json | Maps the stall_percentage measurement to app.vitals.stall.percentage. |
| model/measurements/frames_slow_rate.json | Maps the frames_slow_rate measurement to app.vitals.frames.slow.rate. |
| model/measurements/frames_frozen_rate.json | Maps the frames_frozen_rate measurement to app.vitals.frames.frozen.rate. |
| model/attributes/stall_total_time.json | Deprecates legacy attribute in favor of app.vitals.stall.duration with alias + backfill status. |
| model/attributes/stall_percentage.json | Deprecates legacy attribute in favor of app.vitals.stall.percentage with alias + backfill status. |
| model/attributes/frames_slow_rate.json | Deprecates legacy attribute in favor of app.vitals.frames.slow.rate with alias + backfill status. |
| model/attributes/frames_frozen_rate.json | Deprecates legacy attribute in favor of app.vitals.frames.frozen.rate with alias + backfill status. |
| model/attributes/app/app__vitals__stall__percentage.json | Defines new stable app.vitals.stall.percentage attribute + alias from legacy. |
| model/attributes/app/app__vitals__stall__duration.json | Defines new stable app.vitals.stall.duration attribute + alias from legacy. |
| model/attributes/app/app__vitals__frames__slow__rate.json | Defines new stable app.vitals.frames.slow.rate attribute + alias from legacy. |
| model/attributes/app/app__vitals__frames__frozen__rate.json | Defines new stable app.vitals.frames.frozen.rate attribute + alias from legacy. |
| javascript/sentry-conventions/src/attributes.ts | Regenerates TS exports/types/metadata for new stable attributes and legacy deprecations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Adds stable app.vitals.* names for derived mobile performance attributes:
Deprecates the legacy names with bidirectional aliases and backfill status, updates measurement mappings, and regenerates the JavaScript and Python bindings.
The OpenTelemetry application registry was checked and has no exact equivalents for these derived frame rates or React Native stall aggregates.
Testing
Closes #372