Repository navigation
feat(attributes): Add litestar.middleware_name (deprecated) in favor of middleware.name - #486
Conversation
…r of `middleware.name` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧Attribute
Attributes
Deps
Other
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d0843ad. Configure here.
| }, | ||
| "is_in_otel": false, | ||
| "example": "AuthenticationMiddleware", | ||
| "alias": ["middleware.name"], |
There was a problem hiding this comment.
Incomplete middleware alias symmetry
Medium Severity
litestar.middleware_name joins the middleware.name alias group that already includes starlette.middleware_name, but the peer aliases are incomplete. litestar.middleware_name only lists middleware.name, and starlette.middleware_name was not updated to include litestar.middleware_name. Alias groups here are expected to be fully symmetric.
Reviewed by Cursor Bugbot for commit d0843ad. Configure here.


Summary
litestar.middleware_nameas a deprecated attribute withmiddleware.nameas its replacementlitestar.middleware_nameas an alias onmiddleware.nameNote: This PR will conflict with #485 (
starlette.middleware_name) on themiddleware.namealias array — whichever merges second will need a rebase to combine both aliases.Test plan
yarn testpasses (7592 JS tests + 3 Python tests)yarn run generateran successfully🤖 Generated with Claude Code