Skip to content

feat(attributes): Add litestar.middleware_name (deprecated) in favor of middleware.name - #486

Merged
sentrivana merged 4 commits into
mainfrom
ivana/add-deprecated-litestar-middleware-name
Jul 23, 2026
Merged

sentrivana merged 4 commits into
mainfrom
ivana/add-deprecated-litestar-middleware-name

Conversation

@sentrivana

@sentrivana sentrivana commented Jul 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds litestar.middleware_name as a deprecated attribute with middleware.name as its replacement
  • Adds litestar.middleware_name as an alias on middleware.name

Note: This PR will conflict with #485 (starlette.middleware_name) on the middleware.name alias array — whichever merges second will need a rebase to combine both aliases.

Test plan

  • yarn test passes (7592 JS tests + 3 Python tests)
  • yarn run generate ran successfully

🤖 Generated with Claude Code

…r of `middleware.name`

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 10, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add litestar.middleware_name (deprecated) in favor of middleware.name by sentrivana in #486
  • Add starlette.middleware_name (deprecated) in favor of middleware.name by sentrivana in #485
  • Add redis.key (deprecated) in favor of db.redis.key by sentrivana in #484
  • Add db.mongodb.collection (deprecated) in favor of db.collection.name by sentrivana in #483
  • Add Kafka messaging attributes by chargome in #474
  • Deprecate rpc.grpc.status_code in favor of rpc.response.status_code by lucas-zimerman in #494
  • Add deprecated messaging.destination_kind by andreiborza in #509
  • Add sentry.segment.name.source attribute by Lms24 in #466
  • Add attribute transformations by constantinius in #465
  • Add stable app vitals attributes by buenaflor in #493
  • Deprecate sentry.frames.* attributes by buenaflor in #500
  • Add missing AI legacy aliases from Relay SpanData by vgrozdanic in #498

Other

  • (conventions) Support multiple examples by Lms24 in #505
  • (descriptions) Add http.route description template for http.server span description inference by Lms24 in #518

Internal Changes 🔧

Attribute

  • Add more examples for valid sentry.kind values by Lms24 in #517
  • Improve db.statement example and add deprecation reason by Lms24 in #501

Attributes

  • Improve description of sentry.segment.name.source by Lms24 in #511
  • Deprecate sentry.span.source and change backfill status of sentry.source by Lms24 in #510

Deps

  • Bump js-yaml from 4.2.0 to 4.3.0 by dependabot in #516
  • Bump astro from 6.4.7 to 7.1.0 in /docs by dependabot in #514

Other

  • (attrs) Backport attributes and normalizations from Relay by Dav1dde in #497
  • (codeowners) Assign telemetry-experience to gen_ai/ai attributes by vgrozdanic in #506
  • (deps-dev) Bump tar from 7.5.16 to 7.5.19 by dependabot in #515
  • (release) Show version in workflow run title by constantinius in #504

🤖 This preview updates automatically when you update the PR.

@sentrivana
sentrivana marked this pull request as ready for review July 10, 2026 09:30
@sentrivana
sentrivana requested review from a team, Lms24, cleptric, mjq and nsdeschenes as code owners July 10, 2026 09:30
@sentrivana
sentrivana merged commit bf86cfb into main Jul 23, 2026
12 checks passed
@sentrivana
sentrivana deleted the ivana/add-deprecated-litestar-middleware-name branch July 23, 2026 09:24

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d0843ad. Configure here.

},
"is_in_otel": false,
"example": "AuthenticationMiddleware",
"alias": ["middleware.name"],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete middleware alias symmetry

Medium Severity

litestar.middleware_name joins the middleware.name alias group that already includes starlette.middleware_name, but the peer aliases are incomplete. litestar.middleware_name only lists middleware.name, and starlette.middleware_name was not updated to include litestar.middleware_name. Alias groups here are expected to be fully symmetric.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d0843ad. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants