Repository navigation
feat(attributes): Add server_name (deprecated) - #477
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
…er.address` Add server_address as a deprecated attribute pointing to server.address as the correct OTel-aligned replacement. Update server.address aliases to include server_address for symmetry. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
63d97a3 to
0e89b2f
Compare
The generated attributes file was out of sync with the model, causing CI to fail on the uncommitted-changes check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 9be3515.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f4ab733. Configure here.
Add `server_address` to the alias lists of `http.server_name`, `net.host.name`, and `http.host`, and add those three to the alias list of `server_address`. This ensures every member of the alias group references every other member, matching the pattern used by other deprecated attributes like `faas.execution`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
server_address (deprecated) in favor of server.addressserver_name (deprecated) and sentry.metric.source
…ted) The deprecated attribute should be server_name, not server_address. Update all alias references across the server.address alias group. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ddd7d3a to
237ab20
Compare
server_name (deprecated) and sentry.metric.sourceserver_name (deprecated)
| "reason": "This attribute is being deprecated in favor of server.address, which is the OTel-aligned replacement." | ||
| }, | ||
| "visibility": "public", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [], | ||
| "description": "Added server_name attribute, deprecated in favor of server.address" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Bug: The change introduces an asymmetric alias relationship. http.host aliases both server_name and client.address, but server_name does not alias client.address, violating the required symmetry.
Severity: LOW
Suggested Fix
To resolve the CI failure, the alias relationship must be made symmetric. Either add client.address to the alias list in model/attributes/server_name.json or remove server_name from the alias list in model/attributes/http/http__host.json.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: model/attributes/server_name.json#L1-L24
Potential issue: The codebase enforces a strict symmetry requirement for attribute
aliases, validated by the "alias group consistency" test. This change breaks that
symmetry. Specifically, `http.host` includes both `server_name` and `client.address` in
its alias list, creating an alias group. However, the updated `server_name` attribute
does not include `client.address` in its own alias list. This inconsistency will cause
the `aliases should be symmetric` test in `test/attributes.test.ts` to fail, which will
block the pull request from being merged.
Also affects:
model/attributes/http/http__host.json:7~13
Did we get this right? 👍 / 👎 to inform future reviews.

Add
server_nameas a deprecated attribute pointing toserver.addressas the OTel-aligned replacement, following the same pattern as other recent deprecations (faas.id→cloud.resource_id,faas.execution→faas.invocation_id). Theserver.addressalias list is updated to includeserver_name.