Skip to content

fix: Change http.request/response.header.<key> to pii: "true" - #201

Merged
lcian merged 3 commits into
mainfrom
lcian/headers-pii
Dec 10, 2025
Merged

lcian merged 3 commits into
mainfrom
lcian/headers-pii

Conversation

@lcian

@lcian lcian commented Dec 9, 2025 •

Copy link
Copy Markdown
Member

This was uncovered in INC-1512.
While this hasn't directly or indirectly caused it, and changing this value wouldn't have prevented the incident, we should generally default to true for arbitrary headers, and possibly allowlist specific headers we know are safe from sensitive info.

@lcian
lcian marked this pull request as draft December 9, 2025 10:18
@lcian
lcian marked this pull request as ready for review December 9, 2025 14:53
@lcian
lcian merged commit c941000 into main Dec 10, 2025
12 checks passed
@lcian
lcian deleted the lcian/headers-pii branch December 10, 2025 08:09
@github-actions

Copy link
Copy Markdown
Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Fixes

- "true"` ([#201](https://github.com/getsentry/sentry-conventions/pull/201))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against d6c320c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants