You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(attributes): Normalize deprecated db attribute names - #199
Normalizes deprecated db attributes. It's important that these attributes get their names normalized to the latest convention because we normalize their values afterwards (and we expect the latest attribute names during normalization).
Backfills deprecated db attributes. It's important that these attributes get their names normalized to the latest convention because we normalize their values afterwards (and we expect the latest attribute names during normalization).
So you always want to read the value from the non-deprecated name, right?
Then what you want is normalize, not backfill.
Backfills deprecated db attributes. It's important that these attributes get their names normalized to the latest convention because we normalize their values afterwards (and we expect the latest attribute names during normalization).
So you always want to read the value from the non-deprecated name, right? Then what you want is normalize, not backfill.
Good point, we would always read from the non deprecated name so it makes sense to drop the deprecated one. Updated!
Ahmed-Labs
changed the title
chore(attributes): Backfill db attributes for normalization
chore(attributes): Normalize deprecated db attribute names
Dec 3, 2025
The reason will be displayed to describe this comment to others. Learn more.
Before merging, please ensure that nothing relies on the old attribute names, as with this change we won't write to those anymore. There might be code paths that still read from them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalizes deprecated db attributes. It's important that these attributes get their names normalized to the latest convention because we normalize their values afterwards (and we expect the latest attribute names during normalization).