Skip to content

chore(attributes): Normalize deprecated db attribute names - #199

Merged
Ahmed-Labs merged 3 commits into
mainfrom
ahmed/chore/backfill-db-attributes
Dec 9, 2025
Merged

Ahmed-Labs merged 3 commits into
mainfrom
ahmed/chore/backfill-db-attributes

Conversation

@Ahmed-Labs

@Ahmed-Labs Ahmed-Labs commented Dec 2, 2025 •

Copy link
Copy Markdown
Contributor

Normalizes deprecated db attributes. It's important that these attributes get their names normalized to the latest convention because we normalize their values afterwards (and we expect the latest attribute names during normalization).

@Ahmed-Labs
Ahmed-Labs marked this pull request as ready for review December 2, 2025 15:58
@lcian

lcian commented Dec 2, 2025

Copy link
Copy Markdown
Member

Backfills deprecated db attributes. It's important that these attributes get their names normalized to the latest convention because we normalize their values afterwards (and we expect the latest attribute names during normalization).

So you always want to read the value from the non-deprecated name, right?
Then what you want is normalize, not backfill.

@Ahmed-Labs

Copy link
Copy Markdown
Contributor Author

Backfills deprecated db attributes. It's important that these attributes get their names normalized to the latest convention because we normalize their values afterwards (and we expect the latest attribute names during normalization).

So you always want to read the value from the non-deprecated name, right? Then what you want is normalize, not backfill.

Good point, we would always read from the non deprecated name so it makes sense to drop the deprecated one. Updated!

@Ahmed-Labs Ahmed-Labs changed the title chore(attributes): Backfill db attributes for normalization chore(attributes): Normalize deprecated db attribute names Dec 3, 2025

@lcian lcian left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, please ensure that nothing relies on the old attribute names, as with this change we won't write to those anymore. There might be code paths that still read from them.

@Ahmed-Labs
Ahmed-Labs merged commit 4cd8753 into main Dec 9, 2025
1 check passed
@Ahmed-Labs
Ahmed-Labs deleted the ahmed/chore/backfill-db-attributes branch December 9, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants