Repository navigation
ref(transactions): Apply convention normalizations to transaction spans - #6223
Merged
Merged
Conversation
Dav1dde
force-pushed
the
dav1d/rm-span-data-fields
branch
4 times, most recently
from
July 15, 2026 06:58
00162e3 to
3fcc036
Compare
Dav1dde
marked this pull request as ready for review
July 15, 2026 06:58
loewenheim
reviewed
Jul 15, 2026
loewenheim
left a comment
Contributor
There was a problem hiding this comment.
This will be a huge simplification for the future. I'm wondering if it wouldn't be simpler in a way to replace SpanData with Attributes entirely—the problem there being that they parse differently.
Member
Author
Potentially, the issue we will also have to serialize it differently (because we need the old Schema within transactions). |
Dav1dde
force-pushed
the
dav1d/rm-span-data-fields
branch
from
July 15, 2026 07:44
3fcc036 to
e15db94
Compare
Dav1dde
force-pushed
the
dav1d/rm-span-data-fields
branch
from
July 15, 2026 08:00
e15db94 to
8dcb972
Compare
Dav1dde
force-pushed
the
dav1d/rm-span-data-fields
branch
from
July 15, 2026 08:45
03ab3ed to
6615cd0
Compare
Dav1dde
force-pushed
the
dav1d/rm-span-data-fields
branch
from
July 15, 2026 09:02
a76a88f to
e2b729d
Compare
loewenheim
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves all usages of
SpanDatato a key and convention based access. The prior functionality oflegacy_aliashas been migrated to use conventions deprecation information.This requires these convention PRs to be merged ✅:
sentry.frames.*attributes sentry-conventions#500Commits can be reviewed in order to get an idea what was changed.
SpanDataand access.otherdirectlySpanDataetc.