Skip to content

ref(transactions): Apply convention normalizations to transaction spans - #6223

Merged
Dav1dde merged 6 commits into
masterfrom
dav1d/rm-span-data-fields
Jul 15, 2026
Merged

Dav1dde merged 6 commits into
masterfrom
dav1d/rm-span-data-fields

Conversation

@Dav1dde

@Dav1dde Dav1dde commented Jul 14, 2026 •

Copy link
Copy Markdown
Member

Moves all usages of SpanData to a key and convention based access. The prior functionality of legacy_alias has been migrated to use conventions deprecation information.

This requires these convention PRs to be merged ✅:

Commits can be reviewed in order to get an idea what was changed.

  1. Remove all fields from SpanData and access .other directly
  2. Implement conventions normalizations for transactions
  3. Implement conventions normalizations for the legacy pipeline
  4. Update sentry-conventions, go over all integration tests, simplify/cleanup code by adding more helpers for SpanData etc.

@Dav1dde Dav1dde self-assigned this Jul 14, 2026
@Dav1dde
Dav1dde force-pushed the dav1d/rm-span-data-fields branch 4 times, most recently from 00162e3 to 3fcc036 Compare July 15, 2026 06:58
@Dav1dde
Dav1dde marked this pull request as ready for review July 15, 2026 06:58
@Dav1dde
Dav1dde requested a review from a team as a code owner July 15, 2026 06:58
cursor[bot]

This comment was marked as resolved.

@loewenheim loewenheim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a huge simplification for the future. I'm wondering if it wouldn't be simpler in a way to replace SpanData with Attributes entirely—the problem there being that they parse differently.

@Dav1dde

Dav1dde commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

I'm wondering if it wouldn't be simpler in a way to replace SpanData with Attributes entirely—the problem there being that they parse differently.

Potentially, the issue we will also have to serialize it differently (because we need the old Schema within transactions).

@Dav1dde
Dav1dde force-pushed the dav1d/rm-span-data-fields branch from 3fcc036 to e15db94 Compare July 15, 2026 07:44
@Dav1dde
Dav1dde force-pushed the dav1d/rm-span-data-fields branch from e15db94 to 8dcb972 Compare July 15, 2026 08:00
@Dav1dde
Dav1dde force-pushed the dav1d/rm-span-data-fields branch from 03ab3ed to 6615cd0 Compare July 15, 2026 08:45
cursor[bot]

This comment was marked as low quality.

@Dav1dde
Dav1dde force-pushed the dav1d/rm-span-data-fields branch from a76a88f to e2b729d Compare July 15, 2026 09:02
@Dav1dde
Dav1dde added this pull request to the merge queue Jul 15, 2026
Merged via the queue into master with commit 4b0eeb4 Jul 15, 2026
34 checks passed
@Dav1dde
Dav1dde deleted the dav1d/rm-span-data-fields branch July 15, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants