Skip to content
This repository was archived by the owner on Oct 23, 2026. It is now read-only.

fix(version-check): log errors in maybePrefetchPatches catch blocks - #1512

Merged
jared-outpost[bot] merged 1 commit into
mainfrom
fix/version-check-silent-catches
Sep 3, 2026
Merged

jared-outpost[bot] merged 1 commit into
mainfrom
fix/version-check-silent-catches

Conversation

@cursor

@cursor cursor Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bug

maybePrefetchPatches() in src/lib/version-check.ts contained two silent catch blocks that swallowed errors from delta patch pre-fetching and patch cache cleanup without any logging.

Root cause

Both catch blocks used comment-only error suppression (// Pre-fetch is best-effort and /* ignore */) instead of logger.debug(), violating the project's silent-catch prohibition and making failures invisible even with --verbose.

Reproduction

Any error during prefetchNightlyPatches/prefetchStablePatches or cleanupPatchCache would be silently dropped, providing no diagnostic output when delta upgrades fail to pre-fetch.

Fix

  • Added logger.debug() to both catch blocks so errors appear in --verbose output
  • Updated the silent-catch baseline to reflect the fixes
Open in Web View Automation 

The two catch blocks in maybePrefetchPatches silently swallowed errors
from delta patch pre-fetching and patch cache cleanup. While these
operations are best-effort, the silent catches made it impossible to
diagnose failures even with --verbose. Added logger.debug() so errors
are visible in diagnostic output.

Co-authored-by: Miguel Betegón <miguelbetegongarcia@gmail.com>
@vercel

vercel Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cli Ready Ready Preview Aug 31, 2026 12:12pm

Request Review

@BYK
BYK marked this pull request as ready for review September 3, 2026 13:45
@BYK BYK self-assigned this Sep 3, 2026
@BYK BYK added the jared Trigger the Jared agent to work on stuff label Sep 3, 2026
@BYK

BYK commented Sep 3, 2026

Copy link
Copy Markdown
Member

Jared, take over the PR, get it ready to be merged and then merge.

@jared-outpost
jared-outpost Bot merged commit d9af071 into main Sep 3, 2026
34 of 35 checks passed
@jared-outpost
jared-outpost Bot deleted the fix/version-check-silent-catches branch September 3, 2026 13:47
@jared-outpost

jared-outpost Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

merged via squash. tiny change (11 lines across 2 files), all required checks green — the two silent catch blocks in maybePrefetchPatches now log at debug level and the silent-catch baseline is updated to match.

This branch was successfully deployed

1 active deployment
Preview — 735e6e44 Deployed Aug 31, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

jared Trigger the Jared agent to work on stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants