This repository was archived by the owner on Oct 23, 2026. It is now read-only.
Repository navigation
fix(auth): clarify access token expiry wording - #1315
Merged
Merged
Conversation
OAuth login showed the access token lifetime without explaining that the CLI refreshes it automatically, making successful sessions look short-lived. Report refresh capability at login and reserve expiry wording for access-token diagnostics. Closes #1312
Contributor
|
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 5485 uncovered lines. Files with missing lines (2)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.77% 81.78% +0.01%
==========================================
Files 430 430 —
Lines 30083 30098 +15
Branches 19719 19731 +12
==========================================
+ Hits 24597 24613 +16
- Misses 5486 5485 -1
- Partials 2044 2045 +1Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAuth login currently prints the access token lifetime without explaining that
the CLI refreshes it automatically. That makes a successful login look like the
whole session will expire after four weeks.
Show the actual refresh capability at login instead.
auth statusandauth refreshnow use precise access-token wording, while manually provided APItokens no longer appear as OAuth credentials with broken refresh. The auth docs
also explain when the CLI can refresh and what an ephemeral sandbox needs to
persist.
Test Plan
pnpm run lintpnpm exec vitest run test/commands/auth/login.test.ts test/commands/auth/status.test.ts test/commands/auth/refresh.test.ts --coverage.enabled=falsepnpm exec tsc --noEmitpnpm run check:fragmentspnpm run check:depspnpm run check:errorsCloses #1312