Skip to content
This repository was archived by the owner on Oct 23, 2026. It is now read-only.

fix(auth): clarify access token expiry wording - #1315

Merged
betegon merged 1 commit into
mainfrom
bt/fix-auth-token-expiry-wording
Jul 30, 2026
Merged

betegon merged 1 commit into
mainfrom
bt/fix-auth-token-expiry-wording

Conversation

@betegon

@betegon betegon commented Jul 30, 2026

Copy link
Copy Markdown
Member

Summary

OAuth login currently prints the access token lifetime without explaining that
the CLI refreshes it automatically. That makes a successful login look like the
whole session will expire after four weeks.

Show the actual refresh capability at login instead. auth status and
auth refresh now use precise access-token wording, while manually provided API
tokens no longer appear as OAuth credentials with broken refresh. The auth docs
also explain when the CLI can refresh and what an ephemeral sandbox needs to
persist.

Test Plan

  • pnpm run lint
  • pnpm exec vitest run test/commands/auth/login.test.ts test/commands/auth/status.test.ts test/commands/auth/refresh.test.ts --coverage.enabled=false
  • pnpm exec tsc --noEmit
  • pnpm run check:fragments
  • pnpm run check:deps
  • pnpm run check:errors

Closes #1312

OAuth login showed the access token lifetime without explaining that the CLI refreshes it automatically, making successful sessions look short-lived. Report refresh capability at login and reserve expiry wording for access-token diagnostics.

Closes #1312
@github-actions

github-actions Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-30 12:50 UTC

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 5485 uncovered lines.
✅ Project coverage is 81.78%. Comparing base (base) to head (head).

Files with missing lines (2)
File Patch % Lines
src/commands/auth/login.ts 100.00% ⚠️ 1 partials
src/commands/auth/refresh.ts 100.00% ⚠️ 1 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    81.77%    81.78%    +0.01%
==========================================
  Files          430       430         —
  Lines        30083     30098       +15
  Branches     19719     19731       +12
==========================================
+ Hits         24597     24613       +16
- Misses        5486      5485        -1
- Partials      2044      2045        +1

Generated by Codecov Action

@betegon
betegon marked this pull request as ready for review July 30, 2026 12:43
@betegon
betegon merged commit 26ef23d into main Jul 30, 2026
32 checks passed
@betegon
betegon deleted the bt/fix-auth-token-expiry-wording branch July 30, 2026 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to set expiry of the oauth token or set higher defaults

1 participant