Skip to content
This repository was archived by the owner on Oct 23, 2026. It is now read-only.

docs(site): use brand fonts (Dammit Sans headings, Rubik body) - #1183

Merged
BYK merged 3 commits into
mainfrom
docs/site-fonts
Jul 3, 2026
Merged

BYK merged 3 commits into
mainfrom
docs/site-fonts

Conversation

@BYK

@BYK BYK commented Jul 3, 2026 •

Copy link
Copy Markdown
Member

Applies the brand typography from design (Steven Lewis): Dammit Sans for headings, Rubik for body. Code stays JetBrains Mono. Follow-up to the site brand assets (#1181).

Changes

  • Headings → self-hosted Dammit Sans display font. Added via @font-face with a relative url("../fonts/…") so Vite bundles + hashes it and respects the site base (font ships to /_astro/dammit-sans-*.<hash>.otf, base-aware for PR previews). Applied to .sl-markdown-content h1–h6, the page-title h1, and the hero h1 via --sl-font-headings.
  • Body → Rubik, using the theme's own self-hosted Rubik Variable (@sentry/starlight-theme already ships it). Removed the previous Inter override and dropped Rubik from the Google Fonts link — no redundant CDN dependency.
  • Code → JetBrains Mono, kept on Google Fonts (the theme ships IBM Plex Mono, not JetBrains).
  • Font file: docs/src/fonts/dammit-sans-v0.3-bold.otf (the custom v0.3 build).

Notes

  • Dammit Sans is a display face with a limited glyph set (missing # / * \ | ^ _ \ ~), so headings fall back to **Rubik** per-character for any missing glyph. Across all docs the only plain-text heading affected is "TLS / Corporate Proxies" (the /falls back to Rubik); command headings are backtick` (JetBrains Mono), unaffected.
  • Per Steven, Dammit Sans will eventually be scoped to mainly larger headings (h1 + some h2); this PR applies it to all headings as the current "header font" — a one-line narrowing later via --sl-font-headings.
  • Shipped as OTF (8.5 KB); a woff2 conversion is a possible future micro-optimization.

Verification

  • astro build OK (39 pages). Prod build → url(/_astro/dammit-sans-*.otf); DOCS_BASE_PATH=/_preview/pr-1183 build → url(/_preview/pr-1183/_astro/dammit-sans-*.otf). Google Fonts link loads JetBrains Mono only; body resolves to the theme's self-hosted Rubik Variable; headings resolve to Dammit Sans.
  • Independent adversarial review: MERGE (no code blockers). Cursor Bugbot's preview-base font-URL finding fixed in 28048bc0d.

Per design (Steven Lewis): headings use the custom 'Dammit Sans' display font
(self-hosted @font-face), body switches from Inter to Rubik. Code stays
JetBrains Mono.

- docs/public/fonts/dammit-sans-v0.3-bold.otf: self-hosted display face
- cli.css: @font-face, --sl-font -> Rubik, --sl-font-headings -> Dammit Sans;
  apply headings font to .sl-markdown-content h1-h6, .page-title-wrapper h1, .hero h1
- astro.config.mjs: Google Fonts link Inter -> Rubik (JetBrains Mono kept)

Dammit Sans is a display face with a limited glyph set, so headings fall back
to Rubik for any missing glyphs (/ * \ | ^ _ `). Verified via astro build (39
pages): font ships to /fonts/, @font-face + heading var in built CSS, Rubik in
the Google Fonts link.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c105cb0. Configure here.

Comment thread docs/src/styles/cli.css Resolved
@github-actions

github-actions Bot commented Jul 3, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://cli.sentry.dev/_preview/pr-1183/

Built to branch gh-pages at 2026-07-03 07:12 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Comment thread docs/src/styles/cli.css Resolved
@github-actions

github-actions Bot commented Jul 3, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 5199 uncovered lines.
✅ Project coverage is 81.65%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    81.65%    81.65%        —%
==========================================
  Files          410       410         —
  Lines        28334     28334         —
  Branches     18437     18437         —
==========================================
+ Hits         23136     23135        -1
- Misses        5198      5199        +1
- Partials      1893      1892        -1

Generated by Codecov Action

BYK added 2 commits July 3, 2026 07:00
The @font-face used a root-absolute /fonts/... URL, which 404s on PR previews
that serve under a base path (DOCS_BASE_PATH, e.g. /_preview/pr-N) — headings
would fall back to Rubik there. Move the font into src/ and reference it with a
relative URL so Vite bundles + hashes it and rewrites the URL respecting base.

Verified: prod build -> /_astro/dammit-sans-*.otf; DOCS_BASE_PATH=/_preview/pr-1183
build -> /_preview/pr-1183/_astro/dammit-sans-*.otf. Addresses Cursor Bugbot.
@sentry/starlight-theme already self-hosts Rubik (as 'Rubik Variable') and sets
it as the default --sl-font. Point --sl-font (and the headings fallback) at
'Rubik Variable' and drop Rubik from the Google Fonts link — body now uses the
theme's self-hosted face with no redundant CDN dependency. JetBrains Mono (which
the theme does not ship — it uses IBM Plex Mono) stays on Google Fonts.

Also complete the missing-glyph note (# and ~) in the cli.css comment.
@BYK
BYK merged commit 3087921 into main Jul 3, 2026
32 checks passed
@BYK
BYK deleted the docs/site-fonts branch July 3, 2026 07:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant