shard: convert errors to runes before truncating #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39d0c78 to
83c695f
Compare
psFried
approved these changes
Mar 31, 2025
| var statusErr = err.Error() | ||
| if len(statusErr) > MAX_ETCD_ERR_LEN { | ||
| statusErr = statusErr[:MAX_ETCD_ERR_LEN] + " ...[truncated]" | ||
| var err = []rune(err.Error()) |
Contributor
There was a problem hiding this comment.
just to double check: What happens if this error string already contains an invalid utf8 sequence? I'm not 100% certain whether that's even possible, but maybe?
Contributor
Author
There was a problem hiding this comment.
Yep, excellent question: https://go.dev/play/p/cNv5eZBTtbA
Contributor
Author
There was a problem hiding this comment.
Adding a comment to this effect, as I had had to research it as well to ensure it wouldn't panic.
Ensure we don't split in the middle of a UTF-8 codepoint.
83c695f to
e654b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is