-
Notifications
You must be signed in to change notification settings - Fork 56
azure: Invalidate storage client if storage account name changes #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure: Invalidate storage client if storage account name changes #409
Conversation
2184783 to
8e3fa9b
Compare
|
is this ready for review? |
|
No, I've been having all sorts of trouble getting a local stack working so I haven't managed to test this yet :/ |
9aeef70 to
e8ca09f
Compare
We ran into this when a customer changed their storage account name. Fragment listings for their journal were using the wrong storage client, and returning errors complaining about resolving the hostname of the previous storage account, even through the fragment spec correctly specified new storage account name.
e8ca09f to
ccbcfa0
Compare
|
@jgraettinger Okay, finally got my local stack un-broken and validated both that I could reproduce the original problem, and that this fixes it.
|
jgraettinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We ran into this when a customer changed their storage account name. Fragment listings for their journal were returning errors complaining about resolving the hostname of the previous storage account, even through the fragment spec correctly specified new storage account name.
This change is