broker/client: surface JOURNAL_NOT_FOUND from RetryReader #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psFried
approved these changes
Sep 6, 2024
Contributor
psFried
left a comment
There was a problem hiding this comment.
IIRC there's still a reason for considering JOURNAL_NOT_FOUND a retry-able error for appends, due to a race condition when creating new partitions. But this is just for reads, and I also can't think of a reason why we should retry them.
Contributor
Author
|
Now I'm worried about a creation race condition where the broker serving a List RPC sees the journal creation just slightly ahead of the broker to which the Read RPC is directed (the read doesn't have a read-through revision attached). |
JOURNAL_NOT_FOUND is generally not a retry-able condition. It was orignally made so with a "shrug", on the premise that users may create journals after they had started their consumers. In practice, I'm not aware of any utility for it. Also tweak logging to reduce noise in environments that have many journals with no current append volume, where read re-authorizations are somewhat frequently obtained.
a15f5ad to
040492e
Compare
Contributor
Author
|
PTAL -- we'll now make a few attempts if the request doesn't have a read-through revision, and then error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JOURNAL_NOT_FOUND is generally not a retry-able condition. It was orignally made so with a "shrug", on the premise that users may create journals after they had started their consumers. In practice, I'm not aware of any utility for it.
Also tweak logging to reduce noise in environments that have many journals with no current append volume, where read re-authorizations are somewhat frequently obtained.
This change is