gazctl: re-use shard and journal clients #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an old bug in `shards prune` where it failed to use the `--broker.address` argument when creating the client. In addition, this cleans up most of the places where gazctl subcommands were creating multiple new clients for a single operation, and consolidates down to a single client of each type per program invocation.
jgraettinger
approved these changes
Aug 24, 2023
Contributor
jgraettinger
left a comment
There was a problem hiding this comment.
LGTM % more testing
Contributor
Author
|
I tested all the subcommands, and everything seems to be working as intended. And |
psFried
added a commit
to estuary/flow
that referenced
this pull request
Aug 25, 2023
psFried
added a commit
to estuary/flow
that referenced
this pull request
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an old bug in
shards prunewhere it failed to use the--broker.addressargument when creating the client.In addition, this cleans up most of the places where gazctl subcommands were creating multiple new clients for a single operation, and consolidates down to a single client of each type per program invocation.
This change is