consumer: synchronously fail if StartCommit returns a pre-resolved error #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures txnRun fails-fast if StartCommit returns an error. If we don't do this, then txnStep will race a select over the shard's `readCh` with a select of the (failed) OpFuture, and then go on to call ConsumeMessage of a shard which is already in a failing state.
psFried
approved these changes
Jan 6, 2023
| default: | ||
| } | ||
|
|
||
| txn.commitBarrier = barrier |
Contributor
There was a problem hiding this comment.
The txn.commitBarrier now won't be set if we're synchronously returning the error. Are all the other accesses of commitBarrier OK with that? Should it clear the previous value? I looked through the file and didn't see any problems, but just wanted to double check.
psFried
added a commit
that referenced
this pull request
Jan 30, 2023
#329 introduced a change to synchronously fail shards if the result of `store.StartCommit` is immediately available. This is _technically_ a race condition, since some asynchronous operations may still completed and observed by `txnStartCommit`. This changes the test to only match against a portion of the final error message, so that it tolerates the error being returned either synchronously or asyncronously.
psFried
added a commit
that referenced
this pull request
Jan 30, 2023
#329 introduced a change to synchronously fail shards if the result of `store.StartCommit` is immediately available. This is _technically_ a race condition, since some asynchronous operations may still completed and observed by `txnStartCommit`. This changes the test to only match against a portion of the final error message, so that it tolerates the error being returned either synchronously or asyncronously.
psFried
added a commit
that referenced
this pull request
Feb 27, 2023
#329 introduced a change to synchronously fail shards if the result of `store.StartCommit` is immediately available. This is _technically_ a race condition, since some asynchronous operations may still completed and observed by `txnStartCommit`. This changes the test to only match against a portion of the final error message, so that it tolerates the error being returned either synchronously or asyncronously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures txnRun fails-fast if StartCommit returns an error. If we don't do this, then txnStep will race a select over the shard's
readChwith a select of the (failed) OpFuture, and then go on to call ConsumeMessage of a shard which is already in a failing state.This change is