shards unassign command no longer stalls
#322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraettinger
reviewed
May 2, 2022
added 2 commits
May 2, 2022 14:03
This fixes a bug which caused the shard supervisor to stall indefinitely. If it ran `shards unassign` and there was nothing to be unassigned, it would never increment the etcd revision with its transaction. Then when we waited to observe our changes as reflected by the etcd mod revision, we would end up waiting until the next arbitrary transaction to complete. Needless to say, this is not the desired behavior.
The underlying issue is now fixed, but this should prevent the `shards unassign` command from hanging indefinitely in the future.
d392871 to
833a615
Compare
Contributor
Author
|
@jgraettinger Is this good to go out? |
jgraettinger
approved these changes
Jun 28, 2022
Contributor
jgraettinger
left a comment
There was a problem hiding this comment.
Yes, apologies. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug which caused the shard supervisor to stall indefinitely. If it ran
shards unassignand there was nothing to be unassigned, it would never increment the etcd revision with its transaction. Then when we waited to observe our changes as reflected by the etcd mod revision, we would end up waiting until the next arbitrary transaction to complete. Needless to say, this is not the desired behavior.Also adds a timeout to the command more generally.
This change is