Improved input focusing when there are multiple fields #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumailht
added a commit
that referenced
this pull request
Oct 10, 2015
Improved input focusing when there are multiple fields
Contributor
|
@jonathan Thank you for your contribution to Gridforms! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves focusing of inputs when clicking on field containers (see pull requests #10 and #14 for more information). Normal focusing functionality for singular inputs remains the same, but we can now support edge cases like datetime fields and multiple checkboxes/radios.
This change prevents switching input focus when the user clicks on an input. Because of this correction, we're now able to have multiple inputs in a container without focus being triggered on all of them. Along with this, if a user clicks on the field container (i.e. not an input), normal focus functionality will still focus on the first input of the container.