Merged
Conversation
feat: from simple keybindings to commands like in vim
Contributor
Author
|
jaehyun1ee-furiosa/dot-viewer#17 위 PR로 추가로, Keybinding을 기준으로 동작하던 것을 Command를 기준으로 동작하게 수정했습니다. Custom Command를 정의하고 파싱하는 것은 시행착오를 겪으면서 구현해서 커밋 수가 많지만, 이전 코드와 비교하여 로직 자체는 크게 변하지 않았습니다. |
maxstate
reviewed
Feb 22, 2023
maxstate
left a comment
There was a problem hiding this comment.
약간 수정해야 할 것을 제외하고는 문제가 없는 것 같습니다.
첨언하자면, 지금 상황에서는 구조가 많이 바뀌어서 dot-viewer.svg는 유효하지 않을 것 같아서 제외해도 좋을 것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.