Refactor and consolidate Shared project structure.#1045
Merged
iammukeshm merged 2 commits intofullstackhero:mainfrom Oct 19, 2024
Merged
Refactor and consolidate Shared project structure.#1045iammukeshm merged 2 commits intofullstackhero:mainfrom
iammukeshm merged 2 commits intofullstackhero:mainfrom
Conversation
The project structure has been modified to remove the "Shared" project from the "api\modules" directory and add a new "Shared" project in the "Shared" directory. The solution configuration has been updated accordingly. References to the old "Shared" project have been replaced with references to the new "Shared" project. The `TenantConstants` and `IdentityConstants` classes have been moved to the `FSH.Starter.Shared.Authorization` namespace. The `IdentityDbInitializer` and `TokenService` classes have been updated to use the new constants. The `ClaimsPrincipalExtensions` class has been removed. Various endpoint and service classes have been updated to use the new `FSH.Starter.Shared.Authorization` namespace. The `Core.csproj` and `Infrastructure.csproj` files have been updated to reference the new "Shared" project. The `FSH.Framework.Core.Tenant` and `FSH.Framework.Infrastructure.Tenant` namespaces and their associated classes have been removed, and the `FSH.Starter.Shared.Authorization` namespace has been added. Unused namespaces have been removed from multiple files. The `Shared.csproj` file was updated to target .NET 8.0 and enable implicit usings and nullable reference types. New static classes for constants related to image formats, claims, actions, permissions, resources, roles, identity, and tenants have been added.
Renamed `FshAction` to `FshActions` and `FshResource` to `FshResources` across multiple files for consistency: - Updated class names in `FshActions.cs` and `FshResources.cs`. - Modified references in `FshPermissions.cs`, `EntityTableContext.cs`, and various `.razor.cs` files. - Ensured all permission checks and resource assignments use the new class names.
iammukeshm
approved these changes
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1043
The project structure has been modified to remove the "Shared" project from the "api\modules" directory and add a new "Shared" project in the "Shared" directory. The solution configuration has been updated accordingly. References to the old "Shared" project have been replaced with references to the new "Shared" project.
The
TenantConstantsandIdentityConstantsclasses have been moved to theFSH.Starter.Shared.Authorizationnamespace. TheIdentityDbInitializerandTokenServiceclasses have been updated to use the new constants. TheClaimsPrincipalExtensionsclass has been removed.Various endpoint and service classes have been updated to use the new
FSH.Starter.Shared.Authorizationnamespace. TheCore.csprojandInfrastructure.csprojfiles have been updated to reference the new "Shared" project.The
FSH.Framework.Core.TenantandFSH.Framework.Infrastructure.Tenantnamespaces and their associated classes have been removed, and theFSH.Starter.Shared.Authorizationnamespace has been added. Unused namespaces have been removed from multiple files.The
Shared.csprojfile was updated to target .NET 8.0 and enable implicit usings and nullable reference types. New static classes for constants related to image formats, claims, actions, permissions, resources, roles, identity, and tenants have been added.