poudriere.css: Adapt to latest DataTables style to avoid unreadable tables #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ables The newer DataTables imported in ce2146e ("Update DataTables to 1.13.8") started setting every other row to transparent. Since we add the built etc classes to the whole table, this means the entire table's background colour is green etc, and so the transparent rows now allow that colour to shine through, making it hard to read the text. Adapt the CSS selectors to only colour the thead within the whole table so that the rows are restored to being uncoloured, less garish and rather more readable. Note that these classes are also used for the status display at the top, so we need to handle them on things other than tables too, where we continue to just colour the whole element. Fixes freebsd#1114 Fixes: ce2146e ("Update DataTables to 1.13.8")
|
@fel1x-developer thoughts? |
|
@jrtc27 Can you post screenshots of before/after? I cannot access to my FreeBSD instance right now, and I will be able to access to it by the end of August. However, if I see that the changes in the CSS file is clearly reflected in screenshots, I will accept this PR. |
|
I’m away from my laptop until the end of this week, but can provide screenshots when back if still needed |
|
Before: |
|
I'm good with these changes |
|
Ping |
1 similar comment
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer DataTables imported in ce2146e ("Update DataTables to
1.13.8") started setting every other row to transparent. Since we add
the built etc classes to the whole table, this means the entire table's
background colour is green etc, and so the transparent rows now allow
that colour to shine through, making it hard to read the text.
Adapt the CSS selectors to only colour the thead within the whole table
so that the rows are restored to being uncoloured, less garish and
rather more readable. Note that these classes are also used for the
status display at the top, so we need to handle them on things other
than tables too, where we continue to just colour the whole element.
Fixes #1114
Fixes: ce2146e ("Update DataTables to 1.13.8")