Skip to content

Improve error logging for FIRAuthInternalErrorCodeUnexpectedErrorResponse errors - #8704

Merged
rosalyntan merged 7 commits into
masterfrom
rosalyntan.error
Sep 28, 2021
Merged

rosalyntan merged 7 commits into
masterfrom
rosalyntan.error

Conversation

@rosalyntan

@rosalyntan rosalyntan commented Sep 24, 2021 •

Copy link
Copy Markdown
Member

Add NSUnderlyingError to FIRAuthInternalErrorCodeUnexpectedErrorResponse errors.

@rosalyntan rosalyntan changed the title Add underlyingError to FIRAuthInternalErrorCodeUnexpectedErrorResponse errors Improve error logging for FIRAuthInternalErrorCodeUnexpectedErrorResponse errors Sep 24, 2021
@google-oss-bot

google-oss-bot commented Sep 24, 2021 •

Copy link
Copy Markdown
Collaborator

Binary Size Report

Affected SDKs

  • FirebaseAuth

    Type Base (f243335) Head (728367e) Diff
    firebase-ios-sdk ? 1.03 MB ? (?)

Test Logs

@google-oss-bot

google-oss-bot commented Sep 25, 2021 •

Copy link
Copy Markdown
Collaborator

Coverage Report

Affected SDKs

  • FirebaseAuth-iOS-FirebaseAuth.framework

    SDK overall coverage changed from 68.25% (f243335) to 68.29% (728367e) by +0.04%.

    Filename Base (f243335) Head (728367e) Diff
    FIRAuthBackend.m 85.01% 85.07% +0.06%
    FIRAuthErrorUtils.m 74.43% 74.82% +0.40%

Test Logs

@rosalyntan
rosalyntan marked this pull request as ready for review September 25, 2021 00:48
@rosalyntan
rosalyntan requested review from maksymmalyhin and paulb777 and removed request for paulb777 September 27, 2021 13:59

@maksymmalyhin maksymmalyhin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A question. Is the additional info expected to be used by the developers? If yes, it may be worth mentioning the available userInfo keys in the public API docs for better discoverability.

@rosalyntan

rosalyntan commented Sep 28, 2021 •

Copy link
Copy Markdown
Member Author

A question. Is the additional info expected to be used by the developers? If yes, it may be worth mentioning the available userInfo keys in the public API docs for better discoverability.

Ack, the FIRAuthInternalErrorCodeUnexepectedErrorResponse error code is wrapped inside the FIRAuthErrorCodeInternalError public error code, which is presented with the message "An internal error has occurred, print and inspect the error details for more information."

@rosalyntan
rosalyntan merged commit ab74442 into master Sep 28, 2021
@rosalyntan
rosalyntan deleted the rosalyntan.error branch September 28, 2021 20:08
@firebase firebase locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants