Skip to content

Fix bug where app launch messages weren't appearing on iOS - #3237

Merged
christibbs merged 7 commits into
masterfrom
fiam-fix-app-launch-bug
Jun 26, 2019
Merged

christibbs merged 7 commits into
masterfrom
fiam-fix-app-launch-bug

Conversation

@christibbs

Copy link
Copy Markdown
Contributor

There were two issues:

  1. App launch FIAMs come through with a fiamTrigger param in the payload (as opposed to the event param for general analytics events) and we were only validating messages with a fiamTrigger of ON_FOREGROUND.
  2. We needed to add a flow to check for app launch FIAMs at the appropriate time-- after the initial app launch fetch occurs and messages are retrieved and stored into the cache.

Comment thread Firebase/InAppMessaging/Data/FIRIAMMessageDefinition.m Outdated
Comment thread Firebase/InAppMessaging/Flows/FIRIAMMessageClientCache.m Outdated
@morganchen12 morganchen12 added the api: inappmessaging Firebase In App Messaging label Jun 21, 2019
@christibbs
christibbs requested review from charlotteliang and removed request for prakhar1989 June 25, 2019 18:50
@christibbs
christibbs merged commit 16fbcf6 into master Jun 26, 2019
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
@paulb777
paulb777 deleted the fiam-fix-app-launch-bug branch February 2, 2020 01:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: inappmessaging Firebase In App Messaging cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants