Remove useMessagingDelegateForDirectChannel property - #2711
Conversation
ryanwilson
left a comment
There was a problem hiding this comment.
A few nits but mostly LGTM!
* Add quick instructions for building the Zip. Added some instructions to build the zip. Will expand further with releasing information. * Further argument instructions, formatting. * Split out required arguments from optional arguments. * Remove trailing whitespace.
ryanwilson
left a comment
There was a problem hiding this comment.
Sorry - please fix the Travis tests before submitting.
…os-sdk into fcm-message-delegate
|
Not sure the travis failure in Function is related to us: Creating functions in /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/firebase-functions.nPsYJTDH |
paulb777
left a comment
There was a problem hiding this comment.
It looks like GoogleUtilities changes got mixed into this PR?
|
Good catch! Remove those out of this PR. |
This reverts commit aedc47c.
|
Please update the documentation: https://firebase.google.com/docs/cloud-messaging/ios/receive
|
|
Thanks @vol24pl, we'll update the docs. Googlers: See cr/261154357 |
[FCM I/O breaking change] Remove useMessagingDelegateForDirectChannel property
All direct channels (non-apns) messages will be handled by messaging:didReceiveMessage:. Previously iOS 9 and below is handled in application:didReceiveRemoteNotification:fetchCompletionHandler: and this behavior can be changed by setting useMessagingDelegateForDirectChannel to true. Now that all messages by default are handled in messaging:didReceiveMessage:. This boolean value is no longer needed.
If you already have useMessagingDelegateForDirectChannel= YES, or handle all your direct channel messages in messaging:didReceiveMessage:. This change should not affect you.