unconstrain Buffer #11
Conversation
|
ping @feross - it'd be good to resolve this as currently, it breaks a few peoples builds |
|
hey guys, when are we planning to merges these two PRs? |
|
ping @feross |
feross
left a comment
There was a problem hiding this comment.
This PR doesn't make sense. If the goal is to prevent node users from using the npm buffer package, then no change is needed. require('buffer') will always return the built-in buffer package in Node.js. Built-in modules get priority over packages in node_modules.
Tip: the way to require the npm package is require('buffer/')
|
|
||
| if (Buffer.from && Buffer.alloc && Buffer.allocUnsafe && Buffer.allocUnsafeSlow) { | ||
| module.exports = buffer | ||
| module.exports = Buffer |
There was a problem hiding this comment.
This is a huge breaking change. require('buffer') !== Buffer. Try doing require('buffer') and look at what you get.
| throw new TypeError('Argument must be a number') | ||
| } | ||
| return buffer.SlowBuffer(size) | ||
| return Buffer.SlowBuffer(size) |
I was not aware of this. Awesome! |
This, combined with #10 should resolve the issues at large.
buffer, the dependency, is only used inbrowser.js, otherwise the nativeBufferis used (intrinsically) and therefore we shim it if necessary.