Convert to hatch #148
Draft
Convert to hatch #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TomasTomecek
left a comment
There was a problem hiding this comment.
+1 to switch to hatch if it makes our packaging work easier
FrostyX
reviewed
Mar 24, 2025
Member
FrostyX
left a comment
There was a problem hiding this comment.
Thank you for the change @sgallagher,
I tried to build an RPM package based around this change, and it worked fine (apart from a few minor hiccups that I am pointing out in my review)
The only reason why I wanted to stay with Poetry was that we already had it, so it was easier to keep it than getting rid of it. Since you already proposed this PR, it is +1 from me.
Member
|
Two things to point out.
|
Collaborator
Author
So, no different from anything that Google ships, then? (I'll see myself out)
Yeah, I'll take a look. |
Signed-off-by: Stephen Gallagher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we wanted to switch to hatch[ling], this could be a start for that.
Note: this is quick-and-dirty and minimally-tested.