This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Add TLS support to the docker container command line#107
Open
Add TLS support to the docker container command line#107
Conversation
- Introduce two options --port and --protocol which will allow users to override the YAML specification and test using TLS (or on alternate ports) - Properly handle exceptions when we are expecting gzip'ed data but actually get clear text (or invalid compressed data)
- The content of example.com changed, the string be searched for is no longer there. Fix this test to identify a string that is present as of this commit
- When loading files from the host environment, they could contain escaped characters. The backslashes from the YAML need to be preserved
fgsch
reviewed
Nov 30, 2019
fgsch
reviewed
Nov 30, 2019
| parser.add_argument('--protocol', default=None, | ||
| help='Specify protocol: http or https (default http)') | ||
| parser.add_argument('--port', default=None, | ||
| help='Specify port number (default 80)') |
Member
There was a problem hiding this comment.
Is this true (default to 80) or whatever is specified in the yaml files?
fgsch
reviewed
Nov 30, 2019
| parser.add_argument('--destaddr_as_host', action='store_true', | ||
| help='Use destination address as the Host header') | ||
| parser.add_argument('--protocol', default=None, | ||
| help='Specify protocol: http or https (default http)') |
Member
There was a problem hiding this comment.
Is this true (default to http) or whatever is specified in the yaml files?
There was a problem hiding this comment.
Yup, we default the port to 80 in the YAML files.
Member
There was a problem hiding this comment.
Right, but if the yaml file uses something else it won't be.
Personally I'd remove the default from the help.
fgsch
approved these changes
Dec 3, 2019
Member
fgsch
left a comment
There was a problem hiding this comment.
Left my personal preference but either way looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--portand--protocolwhich will allow users to overridethe YAML specification and test using TLS (or on alternate ports)
get clear text (or invalid compressed data)