x64 build fixes #44
Closed
x64 build fixes #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Please avoid unnecessary whitespace changes. Your change seems to change all the indentation... |
Owner
|
Besides: what x64 build error does this fix? The CI runners test compilation on both 32 and 64bit platforms. |
Author
|
Sorry I should have been more clear, I'm compiling with warnings as errors and it fixes warnings. |
Author
|
Fixed the whitespaces but some tabs were already used before so for the sake of consistency changed those to spaces too |
|
I am using this library on vs2015 with 64bit without problems, what do these fixes ? |
Author
|
They fix warnings in the compilation |
Owner
|
The changes break both the CI testers, so I won't merge unless they are green again. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.