[pull] master from robotframework:master #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added minimize keyword
As a way to deal with constantly changing selenium-manager logging which affects our status checking I implemented this change. Works fine with GitHub CI but has some issues on local. In particular under Windows build & test it is problematic under virtualenvs. It is possible to resolve but right now its just too problematic .. so pulling out this change for now.
As written this is an invalid test given current functionality. One can not give a list directly as a locator. (It is possible to check a list of elements by using a cascaded locator in that for the end locator to be found all ther other ones must be there as well. But thi is really a different type of locator as list check). I am not opposed to expanding the functionality to include this but as currently stands I see this as an invilad check on functionality that is not yet provided.
- Updated to latest 6.1.1 version of Robot Framework - Added Selenium v4.16.0 and dropped 4.13.0 from test matrix
The `Test Get Cookie Keyword Logging` test case has a slight issue in that Get Cookie returns the expir date and converts to local timezone. So it makes it difficult to run both within CI and across all our developers timezones without failing. This change is made to correct for that. I do see that we could shift this some more so that UTC expiry keeps within the same day from a California to Australia execution.
- Also renamed the test result archive removing the work "Failed" as they are not always failed.
Switched expected log level from INFO to ANY as for version 7.0b1 has a change that for a change in loglevel downward should affect the logging level of that action. Switched to ANY to allow for both prior verison and future versions to check this.
Triaging the `Test Minimize and Maximize Will Actually Move and Resize Window` test case. There is a known issue with trying to get this to pass and so sort of confirguration needs to be tried out.
…sions Update test under selenium versions
…s-1822 New attribute property keywords 1822
Within the selenium options argument of the `Open Browser` keword, if there were trailing semicolons then the keyword would fail. With this change we allow trailing semicolons. In addition the library warns about emtpy options. Fixes #1877
Made a few changes .. - Catch unknown expoected conditions and reopport an error. This can still be improved by adding a here are the known expected conditions as well as a "did you mean ..." type message - Brought in parser so one can use `Element To Be Clickable` instead of `element_to_be_clicable`. Admittedly it seems to simple and realized an issue, of case, as I type this. - Added some test cases
Hadn't realized I do force the expected condition ame to all lower case letters. So just needed to add a test case!
.. and some minor corrections
The new selenium options parser has a slightly different behaviour when it comes to multiple arguments with generious spacing within its option string. In stead of leaving preceeding and trailing spaces it removes those. This change is approved files corrects for this change.
Also reveted back from expressive matrix options as I need to learn how to use key-value pairs within gh actions.
Also reduce test matrix for now and set setup-chrome action to v1 (as compared to @latest)
Looks like the system has Chrome 1.37 already installed. This will setup chrome 137 somewhere but more importantly add the driver. Realizing I may need to rework how we setup the machine ..
…oss many versions
Previously the timeout was 1 sec and the alert was delayed 500ms. With a normal execution it seems that that 500ms diference is just not long enough to reasonably expect the alert to appear. In reviewing this test it was shown any delay was useful and the needed time for an alert to triggered and then recognized would need more than 500ms.
Latest versions jun2025
Return screenshot as base64 string and embed into log
Remove deprecated is string
Allow python version 3.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )