This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Fix for PyExecJS >= 1.0.5 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test plan: % EXECJS_RUNTIME=Node python ./react/test/__main__.py % EXECJS_RUNTIME=PhantomJS python ./react/test/__main__.py It fails with JavaScriptCore runtime but does so in an older version (probably because of Browserify).
Contributor
Author
|
Fixes #15 |
Contributor
|
Hah, wish I had seen this before publishing 0.5.1. |
blackhatguy24
added a commit
to blackhatguy24/react-python
that referenced
this pull request
Apr 5, 2020
Fix for PyExecJS >= 1.0.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan:
It fails with JavaScriptCore runtime but does so in an older version (probably
because of Browserify).