Recognize PR# at end of commit title for github_pull_request_* templates #881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognize PR# at end of commit title for github_pull_request_* templates
Summary:
On GitHub, commits that are squash/merged from pull requests
such as facebook/dotslash@4c0563c
commonly have the pull request number at the end of
the first line of the commit message like so:
This updates the logic for the various
github_pull_request_*templates to match this pattern.
Note this required adding
repoas an argument to_parse_github_pull_request_url()so that it could producea complete
PullRequestIdobject even if it only hadthe commit number in the commit message.
Test Plan:
Added a
FakeGitHubRepototestutil.pyto make it easierto write doctests against this new logic.
I also looked for a repo that doesn't use Meta's tooling
(so it doesn't have the
Pull Request resolvedline in its commits)and decided to test with https://github.com/google/generative-ai-docs as follows: