Update reviewstack README #1080
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the README to more accurately reflect the current file structure and fix the various markdown lints
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
quark-zju
approved these changes
May 16, 2025
Contributor
quark-zju
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
This pull request has been merged in d269d58. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 16, 2025
Summary: Currently ReviewStack doesn't show the number of lines modified like github, so this diff adds a simple display of it. Requires adding 2 additional fields to the graphQL query Before:  After:  --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/1081). * __->__ #1081 * #1080 Pull Request resolved: #1081 Reviewed By: quark-zju Differential Revision: D74788766 fbshipit-source-id: a14aa55821b12f28d8afd9028019d0c58980f540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the README to more accurately reflect the current file structure and fix the various markdown lints
Stack created with Sapling. Best reviewed with ReviewStack.