Skip to content

Revert "Avoid replaying SelectiveHydrationException in dev" + "Force unwind work loop during selective hydration" #25810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tyao1 wants to merge 2 commits into from
Closed

Revert "Avoid replaying SelectiveHydrationException in dev" + "Force unwind work loop during selective hydration" #25810

tyao1 wants to merge 2 commits into from

Conversation

@tyao1
Copy link
Contributor

@tyao1 tyao1 commented Dec 5, 2022 •
edited
Loading

Reverts #25754 and #25695 to unblock syncing code to WWW

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 5, 2022
@sizebot
Copy link

sizebot commented Dec 5, 2022 •
edited
Loading

Comparing: 2ccfa65...57199f7

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.40 kB 154.26 kB = 49.00 kB 48.94 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.32 kB 156.18 kB = 49.65 kB 49.60 kB
facebook-www/ReactDOM-prod.classic.js = 533.40 kB 532.79 kB = 94.99 kB 94.91 kB
facebook-www/ReactDOM-prod.modern.js = 518.50 kB 517.88 kB = 92.80 kB 92.70 kB
facebook-www/ReactDOMForked-prod.classic.js = 533.40 kB 532.79 kB = 94.99 kB 94.91 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOM-dev.classic.js = 1,356.99 kB 1,354.05 kB = 294.73 kB 294.00 kB
facebook-www/ReactDOMForked-dev.classic.js = 1,356.99 kB 1,354.05 kB = 294.73 kB 294.00 kB
react-native/implementations/ReactNativeRenderer-profiling.js = 342.90 kB 342.15 kB = 60.47 kB 60.32 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 361.36 kB 360.56 kB = 63.48 kB 63.34 kB
facebook-www/ReactDOM-dev.modern.js = 1,332.00 kB 1,329.05 kB = 290.10 kB 289.37 kB
facebook-www/ReactDOMForked-dev.modern.js = 1,332.00 kB 1,329.05 kB = 290.10 kB 289.37 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 334.18 kB 333.44 kB = 59.27 kB 59.11 kB
react-native/implementations/ReactFabric-profiling.js = 336.64 kB 335.88 kB = 59.49 kB 59.35 kB
react-native/implementations/ReactFabric-profiling.fb.js = 355.11 kB 354.31 kB = 62.48 kB 62.34 kB
react-native/implementations/ReactFabric-prod.fb.js = 328.00 kB 327.26 kB = 58.28 kB 58.12 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,236.01 kB 1,233.20 kB = 273.29 kB 272.56 kB
react-native/implementations/ReactNativeRenderer-prod.js = 323.42 kB 322.69 kB = 57.19 kB 57.04 kB
react-native/implementations/ReactFabric-prod.js = 317.23 kB 316.49 kB = 56.24 kB 56.08 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,205.99 kB 1,203.18 kB = 267.46 kB 266.74 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 305.50 kB 304.76 kB = 53.73 kB 53.57 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,205.68 kB 1,202.72 kB = 267.67 kB 266.94 kB
oss-experimental/react-dom/umd/react-dom.development.js = 1,271.55 kB 1,268.41 kB = 272.06 kB 271.23 kB
oss-experimental/react-dom/cjs/react-dom.development.js = 1,212.54 kB 1,209.53 kB = 269.01 kB 268.29 kB
oss-stable/react-dom/umd/react-dom.development.js = 1,260.96 kB 1,257.82 kB = 270.09 kB 269.26 kB
oss-stable-semver/react-dom/umd/react-dom.development.js = 1,260.93 kB 1,257.80 kB = 270.06 kB 269.24 kB
oss-stable/react-dom/cjs/react-dom.development.js = 1,202.50 kB 1,199.49 kB = 267.05 kB 266.31 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js = 1,202.48 kB 1,199.47 kB = 267.03 kB 266.28 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 289.72 kB 288.98 kB = 51.33 kB 51.15 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js = 100.52 kB 100.22 kB = 31.19 kB 31.11 kB
oss-stable/react-test-renderer/umd/react-test-renderer.production.min.js = 100.46 kB 100.16 kB = 31.16 kB 31.08 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.production.min.js = 100.44 kB 100.14 kB = 31.16 kB 31.08 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js = 100.28 kB 99.98 kB = 30.78 kB 30.68 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.min.js = 100.22 kB 99.92 kB = 30.74 kB 30.65 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.min.js = 100.20 kB 99.90 kB = 30.74 kB 30.65 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 891.75 kB 888.80 kB = 193.43 kB 192.70 kB
facebook-www/ReactART-dev.classic.js = 884.07 kB 881.12 kB = 187.09 kB 186.34 kB
react-native/implementations/ReactFabric-dev.fb.js = 882.34 kB 879.39 kB = 191.04 kB 190.30 kB
react-native/implementations/ReactNativeRenderer-dev.js = 855.01 kB 852.15 kB = 186.28 kB 185.58 kB
facebook-www/ReactART-dev.modern.js = 873.61 kB 870.66 kB = 184.97 kB 184.23 kB
react-native/implementations/ReactFabric-dev.js = 845.59 kB 842.72 kB = 183.91 kB 183.21 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 860.48 kB 857.47 kB = 182.96 kB 182.21 kB
oss-experimental/react-art/umd/react-art.development.js = 888.69 kB 885.56 kB = 186.97 kB 186.17 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 852.69 kB 849.68 kB = 181.55 kB 180.77 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js = 852.67 kB 849.65 kB = 181.52 kB 180.74 kB
oss-stable/react-art/umd/react-art.development.js = 880.46 kB 877.32 kB = 185.52 kB 184.74 kB
oss-stable-semver/react-art/umd/react-art.development.js = 880.44 kB 877.30 kB = 185.50 kB 184.72 kB
facebook-www/ReactTestRenderer-dev.classic.js = 783.01 kB 780.20 kB = 168.27 kB 167.53 kB
facebook-www/ReactTestRenderer-dev.modern.js = 783.01 kB 780.20 kB = 168.27 kB 167.53 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 766.62 kB 763.81 kB = 164.92 kB 164.19 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js = 788.27 kB 785.26 kB = 165.00 kB 164.30 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js = 788.17 kB 785.16 kB = 164.97 kB 164.26 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js = 788.14 kB 785.14 kB = 164.94 kB 164.24 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 752.48 kB 749.59 kB = 163.29 kB 162.57 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 752.38 kB 749.49 kB = 163.26 kB 162.54 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js = 752.35 kB 749.47 kB = 163.23 kB 162.51 kB
oss-experimental/react-art/cjs/react-art.development.js = 780.69 kB 777.68 kB = 168.65 kB 167.95 kB
oss-stable/react-art/cjs/react-art.development.js = 772.90 kB 769.89 kB = 167.26 kB 166.55 kB
oss-stable-semver/react-art/cjs/react-art.development.js = 772.88 kB 769.86 kB = 167.24 kB 166.53 kB

Generated by 🚫 dangerJS against 57199f7

@tyao1 tyao1 force-pushed the revert-25754-ty-selective-hydration-exception branch from 1326dfb to 57199f7 Compare December 5, 2022 20:37
@tyao1 tyao1 changed the title Revert "Avoid replaying SelectiveHydrationException in dev" Revert "Avoid replaying SelectiveHydrationException in dev" + "Force unwind work loop during selective hydration" Dec 5, 2022
@tyao1 tyao1 changed the base branch from main to ty-revert-batch-sync-lane December 5, 2022 20:39
@tyao1 tyao1 closed this Dec 5, 2022
@tyao1 tyao1 deleted the revert-25754-ty-selective-hydration-exception branch December 13, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tyao1 @sizebot @facebook-github-bot