Skip to content

add section of stickyHeaderHiddenOnScroll option #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Simek merged 3 commits into from
Oct 5, 2021
Merged

add section of stickyHeaderHiddenOnScroll option #2801

Simek merged 3 commits into from
Oct 5, 2021
+30 −0

Conversation

@grgr-dkrk
Copy link
Contributor

@grgr-dkrk grgr-dkrk commented Oct 4, 2021

Added an entry for the ScrollView optionstickyHeaderHiddenOnScrollto the documentation.
https://github.com/react-native-community/releases/blob/master/CHANGELOG.md#added-1

@grgr-dkrk grgr-dkrk changed the title chore(ScrollView): add stickyHeaderHiddenOnScroll option add section of stickyHeaderHiddenOnScroll option Oct 4, 2021
@netlify
Copy link

netlify bot commented Oct 4, 2021 •
edited
Loading

❌ Deploy Preview for react-native failed.

🔨 Explore the source changes: 8f24c86

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/615b916ee2af9b0009721da6

Simek
Simek requested changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grgr-dkrk, thank you for the docs update! 👍

This generally LGTM, there are only few working tweaks to the description in the suggestion. Please port those to all of the changed files. 🙂

@grgr-dkrk grgr-dkrk requested a review from Simek October 4, 2021 23:50
Simek
Simek approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates, let's ship it! 🙂

@Simek Simek merged commit ab2fc10 into facebook:main Oct 5, 2021
sunnylqm added a commit to reactnativecn/react-native-website that referenced this pull request Oct 9, 2021
@sunnylqm @raquelmsmith
@GijsWeterings @TheDSCPL @Simek @TitusEfferian @yungsters @dependabot @switchtrue @f4z3k4s @ivanmoskalev @cortinico @luism3861 @nanaasiedu @retyui @grgr-dkrk @simonbrunou @jenskuhrjorgensen @miguelSWE
0.66 sync 1009 (#513)
26c19a7 
* Add a note about where to place the Gradle vars (facebook#2776)


Co-authored-by: Gijs Weterings <me@gijsweterings.nl>

* Update appstate.md (facebook#2778)


Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

* Animations: remove unused style object (facebook#2780)

* Force `trim@^1.0.1` resolution (facebook#2782)

* Bump axios from 0.21.1 to 0.21.4 (facebook#2783)

Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.4.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md)
- [Commits](axios/axios@v0.21.1...v0.21.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add help relating to Android intent queries (facebook#2774)

* Add help relating to Android intent queries

On Android 11 in order for `Linking.canOpenUrl` to return `true` the scheme/intent must be specified in AndroidManifest.xml and queryable. This is not currently clear in the documentation even though specific instructions are given for iOS.

* Tweaks from prettier linting.

* Fix spelling mistakes.

Co-authored-by: Gijs Weterings <me@gijsweterings.nl>

* Ensure AndroidManifest.xml example matches the descriptive text.

Co-authored-by: Gijs Weterings <me@gijsweterings.nl>

* Improve wording in the description for the example code.

Co-authored-by: Gijs Weterings <me@gijsweterings.nl>

* Split sentence in two to improve readability

Co-authored-by: Gijs Weterings <me@gijsweterings.nl>

Co-authored-by: Gijs Weterings <me@gijsweterings.nl>

* docs: add fragment to native-components-android.md (facebook#2599)

* docs: add fragment to native-components-android.md

As a Javascript / React-Native developer I had a hard time figuring out how to integrate a custom native SDK to React Native with the help of Android Fragments. Please correct anything that you wish. This information took me 3 days to figure out, especially the part with `setupLayout` and `manuallyLayoutChildren` so I wish an example like this was available in the official documentation. I was expecting the code without `setupLayout` and `manuallyLayoutChildren` but i had no luck. If somebody has any better solution in your team, or any explanation, it would also be really nice to state in the documentation

* chore: fix linting errors

* chore: fix alex errors

* docs: update native-components-android.md

* docs: update native-components-android.md

- add missing imports
- remove extra spaces
- remove unnecessary double cast
- remove unnecessary comment

* Bump semver-regex from 3.1.2 to 3.1.3 (facebook#2788)

Bumps [semver-regex](https://github.com/sindresorhus/semver-regex) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/sindresorhus/semver-regex/releases)
- [Commits](https://github.com/sindresorhus/semver-regex/commits)

---
updated-dependencies:
- dependency-name: semver-regex
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump prismjs from 1.24.0 to 1.25.0 (facebook#2787)

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.24.0 to 1.25.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.24.0...v1.25.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove the link to 2021 React Community Survey (facebook#2784)

* Bump ansi-regex to ^5.0.1 to fix CVE-2021-3807 (facebook#2794)

* Release 0.66 Post (facebook#2797)

* Add post and assets

* Fix lint

* Update links and image

* Ignore alex warning

* Fix linking for highlights

* Capitalize Bluetooth and align titles

* Capitalize Bluetooth and align titles

* Missed one Bluetooth

* Credit mikehardy

* Cut 0.66 docs (facebook#2798)

* update link troubleshooting (facebook#2799)

* Update handling-text-input.md (facebook#2795)

* Update tsconfig.json example (facebook#2796)

* fix preview deploy failure due to links in older blog posts (facebook#2803)

* add section of `stickyHeaderHiddenOnScroll` option (facebook#2801)

* Update native-modules-android.md (facebook#2791)

* Update native-modules-android.md

Those two methods are missing in the documentation and an exception is sent if they are not in the code.

Co-authored-by: Simon BRUNOU <simon.brunou@bystamp.com>

* Update linking.md (facebook#2802)

* [Docs] Add an asterisk note to the hermes bundle is in use (facebook#2804)

Co-authored-by: Raquel Smith <raquelmsmith@users.noreply.github.com>
Co-authored-by: Gijs Weterings <me@gijsweterings.nl>
Co-authored-by: Luis Durão <luis.p.durao@gmail.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Titus Efferian <kiritosato@gmail.com>
Co-authored-by: Timothy Yung <yungsters@fb.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mike Leonard <mike.r.leonard@gmail.com>
Co-authored-by: Fazekas Dániel <daniel.tamas.fazekas@gmail.com>
Co-authored-by: Ivan Moskalev <ivan.moskalev@gmail.com>
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
Co-authored-by: Luna <luwe@fb.com>
Co-authored-by: Luis Medina Huerta <luism3861@gmail.com>
Co-authored-by: Nana Asiedu-Ampem <nanaasiedu0@gmail.com>
Co-authored-by: David NRB <4661784+retyui@users.noreply.github.com>
Co-authored-by: guruguru-dekiruko <40130327+grgr-dkrk@users.noreply.github.com>
Co-authored-by: Simon <5848809+simonbrunou@users.noreply.github.com>
Co-authored-by: Simon BRUNOU <simon.brunou@bystamp.com>
Co-authored-by: Jens Kuhr Jørgensen <jenskuhr4@gmail.com>
Co-authored-by: limaAniceto <lima.aniceto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Simek Simek Simek approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grgr-dkrk @Simek @facebook-github-bot