docs: add section on installing rustup and wasm32 target#49
docs: add section on installing rustup and wasm32 target#49nilslice merged 6 commits intoextism:mainfrom
Conversation
…n-unknown target if not installed as the example wont build without it
|
@apisorbust - just added a couple suggested changes, but otherwise great addition! If you like, you can accept these changes in the UI here, or make them on your branch and commit & push. |
Co-authored-by: Steve Manuel <nilslice@gmail.com>
Co-authored-by: Steve Manuel <nilslice@gmail.com>
Co-authored-by: Steve Manuel <nilslice@gmail.com>
Co-authored-by: Steve Manuel <nilslice@gmail.com>
|
Accepted your changes. Very nice! |
nilslice
left a comment
There was a problem hiding this comment.
LGTM! just going to let CI run and I'll merge on ✅
|
Thank you, @apisorbust! |
|
|
||
| ```bash | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh | ||
| ``` |
There was a problem hiding this comment.
The placement of this is a little strange because just a moment earlier, the user was running cargo, etc. So if they don't have rust installed they should be failing there right? Should we maybe move this up?
There was a problem hiding this comment.
Good catch. I thought about that but assumed they probably had rust/cargo installed but maybe not rustup. Total noob so wasn't sure if rustup was part of the typical rust install.
There was a problem hiding this comment.
Actually.. should the comment and ### Rustup.. part be up at the top too? Thus this whole bit is at the top? Otherwise just the curl command may look a little odd.
|
|
||
| Once `rustup` is installed, add the `wasm32-unknown-unknown` target: | ||
|
|
||
| ```bash | ||
| rustup target add wasm32-unknown-unknown | ||
| ``` | ||
|
|
||
|
|
There was a problem hiding this comment.
Sorry for the delay here, didn't realize this got left behind...
Actually.. should the comment and ### Rustup.. part be up at the top too? Thus this whole bit is at the top? Otherwise just the curl command may look a little odd.
Do you mean to include this code attached here to the curl command to be moved up?
|
@nilslice does anything else need to be done on this? wasn't sure if the question above is still outstanding |
nilslice
left a comment
There was a problem hiding this comment.
Let's just merge this as-is and we can update later if needed.
When working through the example as a first time rust dev.. I did not have rustup or the wasm32-unknown-unknown target installed. So I had problems building the example. This addition is to help those that may be in a similar boat ensuring they have the necessary target so the build will work.