Skip to content

bindings: Remove remaining Rf_isS4 and R_altrep_Coerce_method_t as we manually define those#254

Merged
JosiahParry merged 1 commit intomasterfrom
hotfix_cached_bindings
Jul 3, 2024
Merged

bindings: Remove remaining Rf_isS4 and R_altrep_Coerce_method_t as we manually define those#254
JosiahParry merged 1 commit intomasterfrom
hotfix_cached_bindings

Conversation

@CGMossa
Copy link
Member

@CGMossa CGMossa commented Jul 2, 2024

Somehow, these bindings was not removed from the cached bindings. I suspect our way of detecting devel might have been wonky, or a git merge went awry.

Either case, here's a potential hotfix.

@JosiahParry
Copy link

Note that these are defined in the lib.rs

libR-sys/src/lib.rs

Lines 80 to 91 in 37fdd30

pub type R_altrep_Coerce_method_t =
::std::option::Option<unsafe extern "C" fn(arg1: SEXP, arg2: SEXPTYPE) -> SEXP>;
pub unsafe fn Rf_isS4(arg1: SEXP) -> Rboolean {
unsafe {
if secret::Rf_isS4_original(arg1) == 0 {
Rboolean::FALSE
} else {
Rboolean::TRUE
}
}
}

@CGMossa do we need to change anything related to the build process to ensure that these functions are removed in the future?

@JosiahParry JosiahParry merged commit 976c56d into master Jul 3, 2024
@CGMossa
Copy link
Member Author

CGMossa commented Jul 3, 2024

I don't think so. Their removal was working on the other generated bindings files.

@CGMossa CGMossa deleted the hotfix_cached_bindings branch July 3, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants