Skip to content

Comments

Detach bindgen for next release#250

Merged
JosiahParry merged 2 commits intomasterfrom
detach_bindgen
Jun 28, 2024
Merged

Detach bindgen for next release#250
JosiahParry merged 2 commits intomasterfrom
detach_bindgen

Conversation

@CGMossa
Copy link
Member

@CGMossa CGMossa commented Jun 28, 2024

For various reasons, we have to make a new release of libR-sys.

This PR removes all uses of bindgen, and removes all features associated with generating bindings.
The currently available bindings in /bindings are those that we will have until #189 is addressed.

After this PR, the MSRV for libR-sys is at: 1.58.1.

@JosiahParry
Copy link

Thank you! I think we need move the deleted build contents into ./create-bindings.rs and in the Cargo.toml write exclude = ["create-bindings.rs"]

@CGMossa
Copy link
Member Author

CGMossa commented Jun 28, 2024

Thank you! I think we need move the deleted build contents into ./create-bindings.rs and in the Cargo.toml write exclude = ["create-bindings.rs"]

I would vote for keeping this PR clean. It removes code, and we publish it, without any clutter. Then after that, we'll make a release, and then we can bring those bits back in.

@JosiahParry
Copy link

I get that. Okie. Let's merge this so we can unblock CRAN fixes.

Copy link

@JosiahParry JosiahParry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Let's merge and work on the xtask

@JosiahParry JosiahParry merged commit 37fdd30 into master Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants