Conversation
thus cross-compile to x86
Ilia-Kosenkov
approved these changes
Apr 23, 2024
Member
Ilia-Kosenkov
left a comment
There was a problem hiding this comment.
Since x86_64 diffs match, I believe it is safe. But let's monitor!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github's default macos-image has changed to ARM-based on. Therefore, we now have to cross-compile from ARM mac to intel mac.
Also, I believe the bindings are out of date, due to messy git rebasing done by me.
Note: This was a guided by @yutannihilation!
Long explanation
I have been resolving conflicts in the opposite direction when doing
git rebase. The term current, when rebasing,refers to the main/master-branch, and not one's PR branch. Or maybe, I'm just mistaken how it should work. Regardless, I believe after a rebase, I should make a
[generate bindings]commit, to truly ensure, that the bindings are correctly generated.