Conversation
|
/bindings |
|
I can approve this because this doesn't remove what should not be removed, but I think I still don't understand the context. Why does Fortran matter here? |
|
I updated the description. These won't work anyways. We don't include the libraries in the compilation. Extendr shouldn't also provide bindings to blas or lapack anyways. I think Rcpp people use other libraries for linear algebra routines, because using these is not good. And them having redundant, not linked, symbols is just wrong. Plus.... It will make librsys smaller in size. With merge extern blocks we went from 4mb to 2.8mb, and this will further help. |
and not `__` like for some other things in the API
|
/bindings |
|
To ease your concern about excluding the wrong items, I've now made a regex, that matches only the items, with one single |
|
Thanks for the explanation.
I don't have such a concern. I just didn't see what's the criteria of what should be included or excluded. |
All Fortran things are renamed, so they have
_appended to their name.We can remove all of these with this PR.
We don't actually load
Rblas.dllorRlapack.dll(on Windows atleast), so I'm not even sure these thingswould work, even if someone called them, meaning this isn't a breaking change.
This is an alternative to removing
Applic.h,BLAS.h,Linpack.h, andLapack.h, as this basically removes the Fortran in all of them, see #197.Note that this PR is more or less another approach to #197.
So only one should be merged; There are no real issues if both are accepted, though.