Skip to content

Remove VECTOR_PTR from bindings#165

Merged
yutannihilation merged 1 commit intomasterfrom
remove_vecptr
May 22, 2023
Merged

Remove VECTOR_PTR from bindings#165
yutannihilation merged 1 commit intomasterfrom
remove_vecptr

Conversation

@CGMossa
Copy link
Member

@CGMossa CGMossa commented Apr 27, 2023

This should have happened with #144.

Best source I can found on the deprecated status of VECTOR_PTR (except the r-source in #144), is

(There is STRING_PTR() which is used in a handful of places in the R source; VECTOR_PTR() is a deprecated interface that now throws an error.)

in https://github.com/hadley/r-internals/blob/master/vectors.md

Copy link
Contributor

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@yutannihilation yutannihilation merged commit 4ad9180 into master May 22, 2023
@yutannihilation yutannihilation deleted the remove_vecptr branch May 22, 2023 23:14
@yutannihilation yutannihilation mentioned this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants