Add suffix arg to compare() and weave_diffs_wide() + close #20#34
Closed
elipousson wants to merge 13 commits intoeutwt:mainfrom
Closed
Add suffix arg to compare() and weave_diffs_wide() + close #20#34elipousson wants to merge 13 commits intoeutwt:mainfrom
suffix arg to compare() and weave_diffs_wide() + close #20#34elipousson wants to merge 13 commits intoeutwt:mainfrom
Conversation
Also: - Export not_equal as an internal function - Make sure `not_equal` returns an index for allow_both_NA = FALSE and allow_both_NA = TRUE
Also add support for `suffix` argument to `compare()`
Also tidy DESCRIPTION w/ `use_tidy_description()`
Add `pull_comparison_table()` and `match_table()` helper Also update test snapshots
Merged
Owner
|
Thanks! I like the idea. To simplify things, I think the I think we can add the user-supplied comparison in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for a great package. I hope this PR is welcome. If you have questions or suggestions, please let me know!
I was interested in adding a suffix argument to
compare()andweave_diffs_wide()and thought I'd work on #20 while I was in the code. Here are the key changes:compare()now supports a custom function for checking equivalence between column values. The existing internal functionnot_equal()is used by default and is now exported FR: user supplied function for detecting differences #20compare()andweave_diffs_wide()both now support asuffixargument to allow custom suffix values for column names when comparing data frames.I also updated the package docs and tidied the DESCRIPTION with usethis.