Skip to content

ENG-3077: fix manual tasks pagination bug#7809

Open
nreyes-dev wants to merge 8 commits intomainfrom
nreyes/eng-3077
Open

ENG-3077: fix manual tasks pagination bug#7809
nreyes-dev wants to merge 8 commits intomainfrom
nreyes/eng-3077

Conversation

@nreyes-dev
Copy link
Copy Markdown
Contributor

@nreyes-dev nreyes-dev commented Apr 1, 2026

Ticket ENG-3077

Description Of Changes

Fixes pagination on the Manual Tasks tab in Privacy Requests where users could not navigate past the first page.

Code Changes

  • Fixed handleTableChange in ManualTasks.tsx to only reset page index when filters actually change, not on every table event. Ant Design's Table.onChange fires for both filter and pagination events, so the unconditional setPageIndex(1) was resetting the page on every click.

Steps to Confirm

  1. Navigate to Privacy Requests > Manual tasks tab
  2. Ensure there are enough tasks to have multiple pages
  3. Click page 2 (or any page beyond 1) and confirm it navigates correctly
  4. Apply a column filter and confirm pagination resets to page 1

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 1, 2026 5:07pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 1, 2026 5:07pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 7%
5.65% (2385/42175) 4.59% (1094/23813) 3.8% (477/12529)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 86%
83.18% (287/345) 77.15% (152/197) 75% (48/64)

@nreyes-dev nreyes-dev marked this pull request as ready for review April 1, 2026 14:42
@nreyes-dev nreyes-dev requested a review from a team as a code owner April 1, 2026 14:42
@nreyes-dev nreyes-dev requested review from gilluminate and removed request for a team April 1, 2026 14:42
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with included mock data. Working well. Ship it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants