Skip to content

ENG-3235: Fix pagination ellipsis wrapping#7803

Merged
gilluminate merged 1 commit intomainfrom
gill/ENG-3235/fix-pagination-ellipsis
Mar 31, 2026
Merged

ENG-3235: Fix pagination ellipsis wrapping#7803
gilluminate merged 1 commit intomainfrom
gill/ENG-3235/fix-pagination-ellipsis

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate commented Mar 31, 2026

Ticket ENG-3235

Description Of Changes

Fixes the Ant Design pagination ellipsis ("...") being too wide and wrapping to the next line. This is caused by default letter-spacing on the ellipsis element making it exceed its container width.

Code Changes

  • Override letter-spacing: 0 and white-space: nowrap on .ant-pagination-item-ellipsis in the global SCSS theme to prevent wrapping

Steps to Confirm

  1. Navigate to any paginated table with enough pages to show the ellipsis (e.g., Systems or Privacy Requests)
  2. Confirm the pagination ellipsis displays inline without wrapping to a second line
CleanShot 2026-03-31 at 11 30 20@2x

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Override letter-spacing and white-space on .ant-pagination-item-ellipsis
to prevent the ellipsis from being too wide and wrapping.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Mar 31, 2026 5:42pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Mar 31, 2026 5:42pm

Request Review

@gilluminate gilluminate marked this pull request as ready for review March 31, 2026 17:31
@gilluminate gilluminate requested a review from a team as a code owner March 31, 2026 17:31
@gilluminate gilluminate requested review from kruulik and removed request for a team March 31, 2026 17:31
@github-actions
Copy link
Copy Markdown

Title Lines Statements Branches Functions
admin-ui Coverage: 7%
5.66% (2385/42079) 4.6% (1094/23761) 3.81% (477/12512)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 86%
83.18% (287/345) 77.15% (152/197) 75% (48/64)

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a small, targeted CSS fix with a matching changelog entry. The change is correct and minimal.

What the fix does

letter-spacing: 0 collapses the extra horizontal space that the Ant Design ellipsis element introduces, and white-space: nowrap prevents it from wrapping to the next line. Both properties are scoped tightly to .ant-pagination-item-ellipsis, so the blast radius is as small as possible.

Observations

  • Correctness: The two properties together address the root symptom (ellipsis too wide → wraps). This is the right approach for a global override in a SCSS theme file.
  • Scoping: The BEM-style nesting (&-item-ellipsis inside .ant-pagination) is consistent with the surrounding file and limits the override to exactly the affected element.
  • Changelog: Entry is correctly typed as Fixed, matches the PR number, and has a clear description.

One nit (inline)

See the inline comment on the // fixes a bug... comment — linking to an upstream issue would make it easier to revisit this workaround when upgrading Ant Design.

Overall this is clean and ready to merge.

}

.ant-pagination {
// fixes a bug where the ellipsis is too wide and wraps to the next line. Maybe they'll fix this.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the comment is clear enough, but it'd be helpful to link to the upstream Ant Design issue/PR here (if one exists) so future readers can easily check whether the fix has landed and this workaround can be removed.

Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed the fix
Image

@gilluminate gilluminate added this pull request to the merge queue Mar 31, 2026
@gilluminate gilluminate removed the request for review from kruulik March 31, 2026 17:40
Merged via the queue into main with commit dd2558a Mar 31, 2026
47 of 49 checks passed
@gilluminate gilluminate deleted the gill/ENG-3235/fix-pagination-ellipsis branch March 31, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants