Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
084ef57 to
49328e5
Compare
chore: update changelog fix: yaml format
49328e5 to
298906a
Compare
There was a problem hiding this comment.
Code Review
Small, targeted fix. Adding allowClear to SharedConfigSelect is the right approach — Ant Design's Select does not expose a clear button by default, and both consuming forms (ConfigureMonitorForm, ConfigureWebsiteMonitorForm) already type shared_config_id as string | undefined, so clearing emits undefined and is handled correctly downstream without any other changes.
One minor nit: The changelog filename has a typo (cofig → config). Also worth verifying whether the existing 7786-fix-monitor-config-select.yaml entry covers a different bug — if so, a slightly more descriptive description here (e.g., "monitor config select can now be cleared after a value is set") would help distinguish the two entries in the release notes.
No blocking issues. LGTM with the nit addressed.
| @@ -0,0 +1,4 @@ | |||
| type: Fixed # One of: Added, Changed, Developer Experience, Deprecated, Docs, Fixed, Removed, Security | |||
| description: monitor config select is now clearable | |||
There was a problem hiding this comment.
Nit: the filename has a typo — cofig instead of config. Also worth double-checking whether this entry overlaps with 7786-fix-monitor-config-select.yaml, which already describes a fix to the shared monitor config select. If these are two separate bug fixes it's fine to keep both entries, but the descriptions are similar enough that it may cause changelog confusion.
Ticket []
Description Of Changes
Fixes small UX where shared config select component is not clearable on the monitor config form
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works