Skip to content

fix: shared monitor config select [ENG-3229]#7786

Merged
speaker-ender merged 4 commits intomainfrom
fix/shared-monitor-config-select
Mar 30, 2026
Merged

fix: shared monitor config select [ENG-3229]#7786
speaker-ender merged 4 commits intomainfrom
fix/shared-monitor-config-select

Conversation

@speaker-ender
Copy link
Copy Markdown
Contributor

@speaker-ender speaker-ender commented Mar 30, 2026

Ticket ENG-3229

Description Of Changes

Fixing broken shared monitor config select not allowing changes or saving

Code Changes

Steps to Confirm

  1. Attempt to create and edit the Shared monitor config field for each monitor type.
  2. Confirm that the value is saved correctly on each submission.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Mar 30, 2026 6:52pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Mar 30, 2026 6:52pm

Request Review

@speaker-ender speaker-ender marked this pull request as ready for review March 30, 2026 18:00
@speaker-ender speaker-ender requested a review from a team as a code owner March 30, 2026 18:00
@speaker-ender speaker-ender requested review from gilluminate and removed request for a team March 30, 2026 18:00
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Vercel and working well! Looks like there's just a Cypress test that needs to be cleaned up.

@speaker-ender speaker-ender added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 5166cf1 Mar 30, 2026
53 of 55 checks passed
@speaker-ender speaker-ender deleted the fix/shared-monitor-config-select branch March 30, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants