-
Notifications
You must be signed in to change notification settings - Fork 92
Add dependency review workflow for PR vulnerability comments #7749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+46
−0
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e816097
Add dependency review CI check for PR vulnerability awareness
daveqnet 195cc0b
TEST: Add vulnerable axios@1.7.0 to sample-app to verify dep review w…
daveqnet 40b2dc4
Disable OpenSSF scorecard, show patched versions, retry on snapshot w…
daveqnet 8ffc176
Add nested lockfile path, disable license checks, fix changelog PR nu…
daveqnet e813ce6
Reduce snapshot retry timeout to 60 seconds
daveqnet a3fd2d8
Disable snapshot retry - retries can't help since snapshot generation…
daveqnet b885d47
Add uv.lock limitation comment, switch to on-failure comments, docume…
daveqnet 222975e
TEST: Add vulnerable ecdsa==0.18.0 to verify Python dep review coverage
daveqnet 2741a57
Revert "TEST: Add vulnerable ecdsa==0.18.0 to verify Python dep revie…
daveqnet e0250ec
Revert "TEST: Add vulnerable axios@1.7.0 to sample-app to verify dep …
daveqnet f886e97
Update uv.lock comment — works in practice despite not being official…
daveqnet a8563c0
Rename changelog file to match expected format
daveqnet 32ce112
Switch back to comment-summary-in-pr: always to clear stale warnings
daveqnet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: Dependency Review | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "uv.lock" | ||
| - "pyproject.toml" | ||
daveqnet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - "clients/package-lock.json" | ||
daveqnet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - "clients/**/package-lock.json" | ||
| - "clients/**/package.json" | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| dependency-review: | ||
| name: Dependency Review | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
|
||
| # NOTE: uv.lock is not in GitHub's official supported ecosystems list, but | ||
| # appears to work in practice. Coverage of transitive Python deps should | ||
| # be verified. See: https://github.com/dependabot/dependabot-core/issues/11913 | ||
| - uses: actions/dependency-review-action@2031cfc080254a8a887f58cffee85186f0e49e48 # v4.9.0 | ||
| with: | ||
| # Always post so that a clean push overwrites any previous warning | ||
| comment-summary-in-pr: always | ||
daveqnet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # fail-on-severity causes the step to fail on HIGH+, but | ||
| # continue-on-error ensures the workflow never blocks merging. | ||
| # The intent is visibility (PR comment) only, not enforcement. | ||
| fail-on-severity: high | ||
daveqnet marked this conversation as resolved.
Show resolved
Hide resolved
daveqnet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| show-openssf-scorecard: false | ||
daveqnet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| show-patched-versions: true | ||
| retry-on-snapshot-warnings: false | ||
| license-check: false | ||
| continue-on-error: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| type: Developer Experience | ||
| description: Added Dependency Review GitHub Actions workflow to surface new dependency vulnerabilities in PR comments | ||
| pr: 7749 | ||
| labels: [] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.